<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Would [Conditional] use through out also not allow us to perform the IDL compile without running the c preprocessor on each file? <div><br></div><div>Can [Conditional] not be fixed to support multiple flags?<br><div><br></div><div>The compiling of IDL is a significant portion of the total build time, and ccache distcc et al cannot help us there.<div><br><div apple-content-edited="true">
<div>Steve "Harry" Coul</div><div><a href="mailto:scoul@cisco.com">scoul@cisco.com</a></div><div><br></div><br class="Apple-interchange-newline">
</div>
<br><div><div>On Mar 7, 2015, at 6:47 PM, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org">rniwa@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"><div dir="ltr"><div class="gmail_extra">On Sat, Mar 7, 2015 at 8:55 AM, Darin Adler <span dir="ltr"><<a href="mailto:darin@apple.com" target="_blank">darin@apple.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Why do we have [Conditional=] in our IDL files? Perhaps because some ports lacked a way to do #if in the past?</blockquote><div><br></div><div>I think Conditional is a nicer/newer way of if-defing based on feature flags.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Should we use #if or [Conditional]? See for example, HTMLMediaElement.idl, which has a mix of both styles. It’s pretty ugly how the #if look in the IDL files, but even worse is a seemingly random mix of both #if and [Conditional].<br></blockquote><div><br></div><div>We should use Conditional as much as possible.</div><div><br></div><div>As far as I know one area we can't use Conditional= is if something depends on multiple feature flags or if it's specific to a binding language (JS/Objective-C/etc...). We should probably add a special feature flag for that; e.g. Conditional=JS.</div><div><br></div><div>- R. Niwa</div><div><br></div></div></div></div>
_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>https://lists.webkit.org/mailman/listinfo/webkit-dev<br></blockquote></div><br></div></div></div></body></html>