<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class="">So what happens to the tag when the logical expression in the ASSERT is changed? Does this generate a new tag?</div><div class=""><br class=""></div><div class="">For me, the filename, function, line number and ASSERT expression are sufficient almost all the time to identify the relevant ASSERT.</div><div class=""><br class=""></div><div class="">I have concerns that creating the tags and associated db will add complexity to the code and our build time and will provide little value.</div><div class=""><br class=""></div><div class="">- Michael</div><div class=""><br class=""></div><br class=""><div><blockquote type="cite" class=""><div class="">On Nov 6, 2014, at 11:44 AM, Said Abou-Hallawa <<a href="mailto:sabouhallawa@apple.com" class="">sabouhallawa@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">The function name and the line number may change if the code changes. A unique tag associated with the assertion should stay the same. So when you want to search for the assertion, you just need the tag since it is unique. We can even extend the dump to do the search in Bugzilla as well. So if the assertion fires, the dump might look like the following:<div class=""><br class=""></div><div class=""><div class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>ASSERTION FAILED (tag: abcde) <i class="">condition</i></div><div class=""><span class=""> Bug 12345 (closed): </span>ASSERTION failed in someFunction</div><div class=""><span class=""> Bug 67890 (open): Still </span>ASSERTION failed in someFunction</div><div class=""><i class=""><span class="Apple-tab-span" style="white-space: pre;"> </span>… rest of the call-stack</i></div></div><div class=""><i class=""><br class=""></i></div><div class=""><span class="">So you do not even need to search Bugzilla for it. You would know immediately that the assertion is being tracked by an opened bug.</span></div></div>_______________________________________________<br class="">webkit-dev mailing list<br class=""><a href="mailto:webkit-dev@lists.webkit.org" class="">webkit-dev@lists.webkit.org</a><br class="">https://lists.webkit.org/mailman/listinfo/webkit-dev<br class=""></div></blockquote></div><br class=""></body></html>