<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><pre style="word-wrap: break-word; white-space: pre-wrap;" class="">I submitted a patch for the bug <a href="https://bugs.webkit.org/show_bug.cgi?id=137132" class="">https://bugs.webkit.org/show_bug.cgi?id=137132</a></pre><pre style="word-wrap: break-word; white-space: pre-wrap;" class="">The build failed for gtk-wk2 but passed for mac and mac-wk2. Here is the failure.</pre><pre style="word-wrap: break-word; white-space: pre-wrap;" class=""><br class=""></pre><pre style="word-wrap: break-word; white-space: pre-wrap;" class="">Last 500 characters of output:</pre><pre style="word-wrap: break-word; white-space: pre-wrap;" class="">e/CMakeFiles/WebCore.dir/rendering/style/RenderStyle.cpp.o -c ../../Source/WebCore/rendering/style/RenderStyle.cpp
../../Source/WebCore/rendering/style/RenderStyle.cpp: In member function 'WebCore::Color WebCore::RenderStyle::colorIncludingFallback(int, bool) const':
../../Source/WebCore/rendering/style/RenderStyle.cpp:1525:10: error: 'CSSPropertyWebkitColumnRuleColor' was not declared in this scope
case CSSPropertyWebkitColumnRuleColor:</pre><div class=""><br class=""></div><div class="">In the patch I have the following change </div><div class=""><br class=""></div><div class=""><h1 style="color: rgb(51, 51, 51); font-family: sans-serif; font-size: 1em; margin-left: 0.5em; display: inline; width: auto; padding: 0.5em; background-color: rgb(248, 248, 248);" class=""><a href="http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/style/RenderStyle.cpp" style="text-decoration: none; border-bottom-width: 1px; border-bottom-style: dotted; color: inherit;" class="">Source/WebCore/rendering/style/RenderStyle.cpp</a></h1><span style="font-family: monospace; font-size: medium; background-color: rgb(248, 248, 248);" class=""></span><div class="DiffSection" style="background-color: white; border-style: solid; border-color: rgb(221, 221, 221); border-width: 1px 0px; font-family: monospace;"><div class="context Line LineContainer" style="white-space: nowrap; color: rgb(136, 68, 153); background-color: rgb(255, 238, 255);"><span class="lineNumber from" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em;">@</span><span class="to lineNumber" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em;">@</span><span class="text" style="padding-left: 5px; white-space: pre-wrap; word-wrap: break-word;">Color RenderStyle::colorIncludingFallbac</span></div><div class="DiffBlock"><div class="DiffBlockPart shared"><div class="Line LineContainer" style="white-space: nowrap;"><span class="lineNumber from" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1522</span><span class="to lineNumber" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1522</span><span class="text" style="padding-left: 5px; white-space: pre-wrap; word-wrap: break-word;"> case CSSPropertyOutlineColor:</span></div><div class="Line LineContainer" style="white-space: nowrap;"><span class="lineNumber from" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1523</span><span class="to lineNumber" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1523</span><span class="text" style="padding-left: 5px; white-space: pre-wrap; word-wrap: break-word;"> result = visitedLink ? visitedLinkOutlineColor() : outlineColor();</span></div><div class="Line LineContainer" style="white-space: nowrap;"><span class="lineNumber from" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1524</span><span class="to lineNumber" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1524</span><span class="text" style="padding-left: 5px; white-space: pre-wrap; word-wrap: break-word;"> break;</span></div></div><div class="clear_float" style="clear: both;"></div></div><div class="DiffBlock"><div class="DiffBlockPart remove" style="background-color: rgb(255, 221, 221);"><div class="remove Line LineContainer" style="white-space: nowrap;"><span class="lineNumber from" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1525</span><span class="to lineNumber" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);"> </span><span class="text" style="padding-left: 5px; white-space: pre-wrap; word-wrap: break-word;"> case CSSProperty<del style="background-color: rgb(238, 153, 153); text-decoration: none;" class="">Webkit</del>ColumnRuleColor:</span></div></div><div class="DiffBlockPart add" style="background-color: rgb(221, 255, 221);"><div class="add Line LineContainer" style="white-space: nowrap;"><span class="lineNumber from" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);"> </span><span class="to lineNumber" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1525</span><span class="text" style="padding-left: 5px; white-space: pre-wrap; word-wrap: break-word;"> case CSSPropertyColumnRuleColor:</span></div></div><div class="clear_float" style="clear: both;"></div></div><div class="DiffBlock"><div class="DiffBlockPart shared"><div class="Line LineContainer" style="white-space: nowrap;"><span class="lineNumber from" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1526</span><span class="to lineNumber" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1526</span><span class="text" style="padding-left: 5px; white-space: pre-wrap; word-wrap: break-word;"> result = visitedLink ? visitedLinkColumnRuleColor() : columnRuleColor();</span></div><div class="Line LineContainer" style="white-space: nowrap;"><span class="lineNumber from" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1527</span><span class="to lineNumber" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1527</span><span class="text" style="padding-left: 5px; white-space: pre-wrap; word-wrap: break-word;"> break;</span></div><div class="Line LineContainer" style="white-space: nowrap;"><span class="lineNumber from" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1528</span><span class="to lineNumber" style="border-bottom-width: 1px; border-bottom-style: solid; border-bottom-color: rgb(153, 153, 136); border-right-width: 1px; border-right-style: solid; border-right-color: rgb(221, 221, 221); color: rgb(68, 68, 68); display: inline-block; padding: 1px 5px 0px 0px; text-align: right; vertical-align: bottom; width: 3em; background-color: rgb(238, 238, 221);">1528</span><span class="text" style="padding-left: 5px; white-space: pre-wrap; word-wrap: break-word;"> case CSSPropertyWebkitTextDecorationColor:</span></div></div></div></div></div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">I am un-prefixing the column rule color property. So I replaced CSSPropertyWebkitColumnRuleColor with CSSPropertyColumnRuleColor. But the failure is saying the prefixed property is not defined. </div><div class=""><br class=""></div><div class="">How can for gtk-wk2 only, the patch is not applied in RenderStyle.cpp but is applied with other files and is applied also for all files for the mac platform?</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Said</div></body></html>