<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Two commit queue issues:</div><div><br></div><div>1. Patches are landing, but bugs aren't being closed. Looks like webkit-patch is failing because a textarea is disabled by default.</div><div><br></div><div>2. Some commit queue patches fail to apply because 'OOPS!' is not being removed from ChangeLog entries.</div><div><br></div><div>Investigating.<br><br>Dave<div>--</div><div>Sent from my iPhone 6</div></div><div><br>On Oct 16, 2014, at 10:58 AM, David Kilzer <<a href="mailto:ddkilzer@webkit.org">ddkilzer@webkit.org</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div>Update complete.</div><div><br></div><div>Please file bugs on <a href="http://bugs.webkit.org">bugs.webkit.org</a> and reply to this thread with the bug.<br><br>Thanks!</div><div><br>Dave<div>--</div><div>Sent from my iPhone 6</div></div><div><br>On Oct 16, 2014, at 10:56 AM, David Kilzer <<a href="mailto:ddkilzer@webkit.org">ddkilzer@webkit.org</a>> wrote:<br><br></div><blockquote type="cite"><div><meta http-equiv="content-type" content="text/html; charset=utf-8"><div><div><div class="AppleOriginalContents" style="direction: ltr;"><div>Sorry, sent this from the wrong address before the update.</div><div><br><blockquote type="cite"><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);">On Oct 16, 2014, at 3:33 AM, Osztrogonác Csaba <<a href="mailto:oszi@inf.u-szeged.hu">oszi@inf.u-szeged.hu</a>> wrote:<br><br></span></font></blockquote></div><blockquote type="cite"><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);">Hi,<br><br>have you tried if the webkit-patch bugzilla tool (upload,<br>apply-attachment, apply-from-bug, ... ), the review tool,<br>the commit queue and EWS will work properly with the new<br>bugzilla version?</span></font></blockquote><div><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div><span style="background-color: rgba(255, 255, 255, 0);">I did verify webkit-patch upload works. We don't have an easy way to test commit queue and EWS outside of the production environment. (That is something we want to improve going forward.)</span></div><div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);">If those are too broken to fix quickly, the plan is to roll back.</span></div><span style="background-color: rgba(255, 255, 255, 0);"><br></span><div><blockquote type="cite" style="background-color: rgba(255, 255, 255, 0);"><font color="#000000">I think they are very fragile and highly rely on the generated<br class="">HTML forms. I prefer fixing these tools before updating to<br class="">breaking them and then trying to fix.</font></blockquote></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);">I wanted to upgrade as soon as possible to patch security issues that were not back-ported to the version we were running.</span></div><span style="background-color: rgba(255, 255, 255, 0);"><br></span><div><blockquote type="cite" style="background-color: rgba(255, 255, 255, 0);"><font color="#000000">Just out of curiosity, if we do an upgrade, why do we upgrade<br class="">to the old stable release (4.2.11), why not the latest stable<br class="">relase (4.4.6)? Is there a fundamental reason for it?</font></blockquote></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);">It was the quickest path to upgrade to a version where security patches were available.</span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);">I had upgraded to 4.2.5 about a year ago, and had qualified over 90% of the website, so it was quickest to upgrade to 4.2.11 rather than 4.4.6 (which could have introduced more compat issues with tools).</span></div><span style="background-color: rgba(255, 255, 255, 0);"><br></span><div><blockquote type="cite" style="background-color: rgba(255, 255, 255, 0);"><font color="#000000">There are many good fixes in 4.4 release. If we can't upgrade<br class="">to 4.4 for some reason, it would be great to cherry-pick at<br class="">least the following changes:<br class=""><br class="">"It is now possible to add yourself to the CC list when uploading an attachment and when editing an existing one." (note)<br class="">--> auto cc reviewer - <a href="https://bugs.webkit.org/show_bug.cgi?id=124047">https://bugs.webkit.org/show_bug.cgi?id=124047</a> )<br class=""><br class="">"Changes to the CC list no longer causes midair collisions." (note)<br class="">--> It is very annoying if you are commenting a bug, and you<br class="">have to start it again if somebody else cc-ed him/herself.<br class="">Or if you clicked force, it would remove these new cc-s.</font></blockquote></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);">After we upgrade to 4.2.11, I will start work on 4.4.6 (plus a way to test the EWS and commit queue with our test environment).</span></div><span style="background-color: rgba(255, 255, 255, 0);"><br></span><div><blockquote type="cite" style="background-color: rgba(255, 255, 255, 0);"><font color="#000000">And one more question: Are you planning to check-in<br class="">the new bugzilla to Websites/<a href="http://bugs.webkit.org/">bugs.webkit.org</a> ?</font></blockquote></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);">Yes. That will be part of the upgrade. It's split into many individual patches (and 3 merge patches); I didn't want to squash-merge it in case it was easier to fix a future bug based on these changes.</span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><span style="background-color: rgba(255, 255, 255, 0);">Dave</span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);"><br></span></div><div class="AppleOriginalContents" style="direction: ltr;"><span style="background-color: rgba(255, 255, 255, 0);"><br></span><div><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);"><blockquote type="cite">(note): <a href="http://www.bugzilla.org/releases/4.4/release-notes.html#v44_feat">http://www.bugzilla.org/releases/4.4/release-notes.html#v44_feat</a><br class=""><br class="">br,<br class="">Ossy</blockquote></span></font></div><blockquote type="cite"><div><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);"><br class="">David Kilzer írta:<br class=""></span></font><blockquote type="cite" class=""><font color="#000000"><span style="background-color: rgba(255, 255, 255, 0);">Hi,<br class="">We’re planning on upgrading Bugzilla (<a href="http://bugs.webkit.org/">bugs.webkit.org</a> <<a href="http://bugs.webkit.org/">http://bugs.webkit.org/</a>>) from 3.2.3 to 4.2.11 on Thursday, October 16 from 8-10 AM PDT <x-apple-data-detectors://1>.<br class="">Sorry for the short notice. I sent this message from the wrong address, and didn't see he bounce message until now.<br class="">Please let me know if you have questions or concerns. Thanks!<br class="">Dave</span></font></blockquote></div><br></blockquote></div></div></div></div></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>webkit-dev mailing list</span><br><span><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a></span><br><span><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev">https://lists.webkit.org/mailman/listinfo/webkit-dev</a></span><br></div></blockquote></div></blockquote><blockquote type="cite"><div><span>_______________________________________________</span><br><span>webkit-dev mailing list</span><br><span><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a></span><br><span><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev">https://lists.webkit.org/mailman/listinfo/webkit-dev</a></span><br></div></blockquote></body></html>