<div dir="ltr">Hi,<br><br>Thx for your replies!<br><br>We also had the solution based on plugin. But we prefer to not use plugins if possible. <br><br>*Some details about our hole element implementation: <br><br>We have created a dedicated TextureMapperHoleBackingStore (which actually could be integrated into TextureMapperSurfaceBackingStore).<br>So we call this GraphicsLayer::setContentsToPlatformLayer function from RenderLayerBacking.cpp. I.e, we have put a new case: “if render().isHole()” at the beginning of the existing black: “if render().isEmbeddedObject () else if render(). isVideo() else if render().isAcceleratedCanvas()” in “RenderLayerBacking::updateGraphicsLayerConfiguration()”.<br>Note that the canvas case happens only if WEB_GL or ACCELERATED_2D_CANVAS is enabled so moving the hole to video element is probably a better option.<br><br>We have validated it on upstream WebKitGtk and WebKitEfl, and the code we put in WebKit is the same for both platforms.<br><br>* It makes sense to move this work to <video>. So instead of having a new tag, we suggest a new style value: <video style=”background=-webkit-hole;”><br>It will also simplify the diff a lot.<br><br>Comments are welcome.<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On 19 September 2014 21:43, José Dapena Paz <span dir="ltr"><<a href="mailto:jdapena@igalia.com" target="_blank">jdapena@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">El jue, 18-09-2014 a las 12:07 -0700, Simon Fraser escribió:<br>
<span class=""><br>
> I don’t think it’s appropriate to add <hole> to WebKit.<br>
><br>
> <hole> is really just adapting to a limitation of the platform’s<br>
> compositing architecture. More powerful hardware like computers and<br>
> smartphones are able to composite video above and below web content,<br>
> which is achieved in WebCore via the accelerated compositing code<br>
> path. I don’t think it’s appropriate to burden the platform with an<br>
> element that only applies on power-limited hardware.<br>
><br>
> The right solution for a WebKit implementation would be to solve this<br>
> via the accelerated composting code. Just use a <video> or <object> in<br>
> your markup, then implement the hole-punching via the GraphicsLayer<br>
> subsystem.<br>
<br>
</span>+1. Implementing punching hole with the integration of GraphicsLayer and<br>
MediaPlayer works well for the videos. Same for plugins.<br>
<br>
I see the punching hole is platform specific. No need for a new HTML<br>
tag.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
</div></div></blockquote></div><br></div>