<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Feb 11, 2014, at 12:29 AM, Žan Doberšek <<a href="mailto:zandobersek@gmail.com">zandobersek@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hi.<br><div class="gmail_extra"><div class="gmail_quote"><br></div><div class="gmail_quote">On Mon, Feb 10, 2014 at 6:30 PM, Dan Bernstein <span dir="ltr"><<a href="mailto:mitz@apple.com" target="_blank">mitz@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Hi everyone, and especially EFL and GTK contributors!</div><div><br></div><div>In preparation for changing <font face="Menlo"><span style="font-size:11px">PLATFORM(MAC)</span></font> to be false when building for iOS, I have been reviewing usage of <font face="Menlo"><span style="font-size:11px">PLATFORM(MAC)</span></font> throughout our codebase. Some of these uses are really about targeting the Darwin OS. However, I could not simply replace <font face="Menlo"><span style="font-size:11px">PLATFORM(MAC)</span></font> with <font face="Menlo"><span style="font-size:11px">OS(DARWIN)</span></font>, because the latter also encompasses the EFL and GTK platforms when building for Darwin (which the former does not). Therefore, thus far I have replaced relevant instances of <font face="Menlo"><span style="font-size:11px">PLATFORM(MAC)</span></font> with <font face="Menlo"><span style="font-size:11px">(OS(DARWIN) && !PLATFORM(EFL) && !PLATFORM(GTK))</span></font>.</div>
</div></blockquote><div><br></div><div>Just to be clear, this is about code that's not appropriate to guard with PLATFORM(COCOA)?</div></div></div></div></blockquote><div><br></div><div>Yup.</div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><br></div><div>This is ugly and seems like a waste of time, so I was wondering:</div><div><br></div><div>1. Is there a configuration of the EFL port that actually builds for Darwin?</div>
<div><br></div><div>2. Is there a configuration of the GTK port that actually builds for Darwin?<br></div></div></blockquote><div><br></div><div>Yes, this configuration is supported by the GTK port through the MacPorts project. Jeremy Huddleston regularly upstreams modifications to properly support building the GTK port on Darwin.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>3. If such configuration(s) exist, would it be OK for them to use Darwin when building for Darwin?</div>
</div></blockquote><div><br></div><div>This could be possible, but it depends really on the code in question. Jeremy would probably be the best candidate to exactly tell you whether the new code is viable to use for the GTK port on Darwin. </div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br></div><div>If the answer to 1 and 2 is no, or if the answer to 3 is yes, then I will simply use <font face="Menlo"><span style="font-size:11px">OS(DARWIN)</span></font> to replace <font face="Menlo"><span style="font-size:11px">PLATFORM(MAC)</span></font> where that is the intent, and, depending on the answers to 1 and 2, update the EFL and GTK build systems to include the Darwin-based implementations where needed.</div>
<div><br></div><div>Thanks!</div></div><br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
<br></blockquote></div><br></div></div>
</blockquote></div><br></body></html>