<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1251"><meta http-equiv="Content-Type" content="text/html charset=windows-1251"><meta http-equiv="Content-Type" content="text/html charset=windows-1251"><meta http-equiv="Content-Type" content="text/html charset=windows-1251"><meta http-equiv="Content-Type" content="text/html charset=windows-1251"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">I dislike this change now that's been rolled out. <div><br></div><div>The lack of email notices before confirmed that my patch was OK and I was able to do something else while waiting for review.<div>Now I have to continually revisit the bug page checking to see if more bots have completed and that my patch is good.</div><div><br></div><div>I think at least the person who submitted the patch should be notified when there's been an error.</div><div><br></div><div><br></div><div><br><div><div>On Jan 17, 2014, at 4:27 PM, Alexey Proskuryakov <<a href="mailto:ap@webkit.org">ap@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1251"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div><br></div><div>This has been implemented, and one unintended consequence is that this noticeably affects how quickly one can iterate on time sensitive patches.</div><div><br></div><div><div>It's a huge waste of time that you are no longer informed when a build fails on EWS. This seriously delays urgent work, as you only start working on fixes when you happen to manually poll, or even worse, when a reviewer tells you about build breakage.</div><div><br></div><div>It's good to not spam everyone, however patch author should be notified by EWS immediately I think. Some ideas:</div><div><br></div><div>- e-mail;</div><div>- IRC;</div><div>- browser notifications when bug page is open.</div><div><br></div><div>The latter might be best, as it also gives some control over whether to get pinged - keep the bug open if you care, close it if it's not urgent, and you cannot afford distraction now.</div></div><div><br></div><div>I filed <a href="https://bugs.webkit.org/show_bug.cgi?id=127203">https://bugs.webkit.org/show_bug.cgi?id=127203</a> about this.</div><br><div><div><span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px;"><div>- WBR, Alexey Proskuryakov</div><br class="Apple-interchange-newline"></span></div><div><br></div><div>16 ÿíâ. 2014 ã., â 15:09, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org">rniwa@webkit.org</a>> íàïèñàë(à):</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Okay, let's remove the python paths but keep the style error messages until we can improve the EWS infrastructure.</div><div class="gmail_extra"><br clear="all"><div>- R. Niwa</div>
<br><br><div class="gmail_quote">On Thu, Jan 16, 2014 at 9:41 AM, Timothy Hatcher <span dir="ltr"><<a href="mailto:timothy@apple.com" target="_blank">timothy@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><div class="h5"><div>On Jan 16, 2014, at 2:28 AM, Alexey Proskuryakov <<a href="mailto:ap@webkit.org" target="_blank">ap@webkit.org</a>> wrote:</div><div><br><blockquote type="cite">
<div style="word-wrap:break-word"><div><br></div><div><div>15 ÿíâ. 2014 ã., â 23:02, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org" target="_blank">rniwa@webkit.org</a>> íàïèñàë(à):</div><br><blockquote type="cite">
<blockquote class="gmail_quote" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>I think that it's good to try not dumping build failures into comments right away, and to see what happens.</div><div><div><br></div><div>As for not showing style bot failures, it seems almost certain that this will make them substantially more annoying to work with. Can you describe the workflow for patch author and reviewer to deal with style bot warnings when they are not inline? Manually finding relevant lines by number can't work.</div>
<div><br></div><div>I agree with Tim that dumping all tested paths along with style warnings is silly. How hard would it be it to get rid of that?</div></div></div></blockquote><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<br></div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
The workflow is to click on the bubble to see the style errors. e.g.</div><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<a href="https://webkit-queues.appspot.com/results/6544662978363392" target="_blank">https://webkit-queues.appspot.com/results/6544662978363392</a><br></div></blockquote></div><div><br></div>Seems like that would require everyone to manually match errors to code lines indeed, so I object against making this change for style checker warnings.<br>
<div><br></div><div>- WBR, Alexey Proskuryakov</div></div></blockquote><br></div></div></div><div><div>Yeah, seeing the style warnings as a comment (which also causes them to show up in the patch review) is helpful. I was just complaining about the python path spew it also includes.</div>
<span class="HOEnZb"><font color="#888888"><br><div><span style="border-collapse:separate;border-spacing:0px">— Timothy Hatcher<br></span></div></font></span></div></div></blockquote></div><br></div>
</blockquote></div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px;"><br></span></div></div>_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br></blockquote></div><br></div></div></body></html>