<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">+1 for the old format.<div><br></div><div>-F</div><div><br></div><div><br><div><div>On Aug 21, 2013, at 11:11 PM, Carlos Garcia Campos <<a href="mailto:carlosgc@webkit.org">carlosgc@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">El mié, 21-08-2013 a las 23:01 -0700, Ryosuke Niwa escribió:<br><blockquote type="cite">On Wed, Aug 21, 2013 at 10:54 PM, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org">rniwa@webkit.org</a>><br>wrote:<br> On Wed, Aug 21, 2013 at 10:50 PM, Carlos Garcia Campos<br> <<a href="mailto:carlosgc@webkit.org">carlosgc@webkit.org</a>> wrote:<br><br> El mié, 21-08-2013 a las 14:04 -0700, Ryosuke Niwa<br> escribió:<br><blockquote type="cite">Hi,<br></blockquote><br> [...]<br><blockquote type="cite"><br>Separately, I'd like to know whether people liked<br></blockquote> the new format and<br><blockquote type="cite">it's worth my time making webkitpy adopt the new<br></blockquote> format.<br><br><br> I prefer the old format.<br><br><blockquote type="cite"><br>I personally didn't like the old format because it<br></blockquote> made the first line<br><blockquote type="cite">of each change log too long. I'm also not a big fun<br></blockquote> of wrapping URLs<br><blockquote type="cite">in angle brackets. It's also unclear to me what<br></blockquote> should happen when<br><blockquote type="cite">there are multiple Bugzilla URLs to list.<br><br><br>But I hear the new format made git log --oneline<br></blockquote> much more readable so<br><blockquote type="cite">I can be convinced although I don't intend to use<br></blockquote> git for WebKit<br><blockquote type="cite">development in the foreseeable future myself.<br></blockquote><br><br> Well, git log is not actually affected by the<br> ChangeLog format, but by<br> the commit message. I mean, we generate the commit<br> message from the<br> ChangeLog, so we can keep the old format in the<br> ChangeLog and update the<br> script to generate the commit message to make it<br> better for oneline git<br> log format. webkitpy parses the ChangeLog not the<br> commit message, so<br> everything should work.<br><br><br> If I'm not mistaken, I think a bunch of tools DO analyze git<br> logs to do the work; commit-queue, webkitbot, etc...<br><br><br>e.g. MarkBugFixed._determine_bug_id_and_svn_revision<br>uses tool.scm().svn_commit_log to figure out the bug number. In fact,<br>the code assumes that the commit log uses the same format as the<br>change log and uses changelog.py's parse_bug_id_from_changelog<br><br><br>In fact, making change log & commit log use a different format is much<br>more challenging than changing the format of change log & commit log.<br>It requires A LOT of refactoring and bug fixes in webkitpy. I don't<br>even know much work is required for webkitperl and other tools.<br></blockquote><br>I see, I thought ChangeLog parser was used everywhere. So, I guess the<br>solution would be to find a format most people like and adapt all<br>scripts to it. I personally think it's not worth it, though. The oneline<br>git log format is ok with the old commit message format IMO. If the only<br>problem is that the bug number is not in the first line we can probably<br>add it without adding the URL in angle brackets, something like:<br><br>Bug 119872 - REGRESSION: Crash under JITCompiler::link while loading Gmail<br><a href="https://bugs.webkit.org/show_bug.cgi?id=119872">https://bugs.webkit.org/show_bug.cgi?id=119872</a><br><br><blockquote type="cite"><br>- R. Niwa<br><br><br></blockquote><br>--<span class="Apple-converted-space"> </span><br>Carlos Garcia Campos<br><a href="http://pgp.rediris.es:11371/pks/lookup?op=get&search=0xF3D322D0EC4582C3">http://pgp.rediris.es:11371/pks/lookup?op=get&search=0xF3D322D0EC4582C3</a><br><br>_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br><a href="https://lists.webkit.org/mailman/listinfo/webkit-dev">https://lists.webkit.org/mailman/listinfo/webkit-dev</a></div></blockquote></div><br></div></body></html>