<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Aug 21, 2013 at 10:54 PM, Ryosuke Niwa <span dir="ltr"><<a href="mailto:rniwa@webkit.org" target="_blank">rniwa@webkit.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="im">On Wed, Aug 21, 2013 at 10:50 PM, Carlos Garcia Campos <span dir="ltr"><<a href="mailto:carlosgc@webkit.org" target="_blank">carlosgc@webkit.org</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><div class="im">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">El mié, 21-08-2013 a las 14:04 -0700, Ryosuke Niwa escribió:<br>
> Hi,<br>
<br>
[...]<br>
<div>><br>
> Separately, I'd like to know whether people liked the new format and<br>
> it's worth my time making webkitpy adopt the new format.<br>
<br>
</div>I prefer the old format.<br>
<div><br>
><br>
> I personally didn't like the old format because it made the first line<br>
> of each change log too long. I'm also not a big fun of wrapping URLs<br>
> in angle brackets. It's also unclear to me what should happen when<br>
> there are multiple Bugzilla URLs to list.<br>
><br>
><br>
> But I hear the new format made git log --oneline much more readable so<br>
> I can be convinced although I don't intend to use git for WebKit<br>
> development in the foreseeable future myself.<br>
<br>
</div>Well, git log is not actually affected by the ChangeLog format, but by<br>
the commit message. I mean, we generate the commit message from the<br>
ChangeLog, so we can keep the old format in the ChangeLog and update the<br>
script to generate the commit message to make it better for oneline git<br>
log format. webkitpy parses the ChangeLog not the commit message, so<br>
everything should work.<br></blockquote><div><br></div></div><div>If I'm not mistaken, I think a bunch of tools DO analyze git logs to do the work; commit-queue, webkitbot, etc...</div></div></div></div></blockquote>
<div><br></div><div style>e.g. MarkBugFixed._determine_bug_id_and_svn_revision uses tool.scm().svn_commit_log to figure out the bug number. In fact, the code assumes that the commit log uses the same format as the change log and uses changelog.py's parse_bug_id_from_changelog</div>
<div style><br></div><div style>In fact, making change log & commit log use a different format is much more challenging than changing the format of change log & commit log. It requires A LOT of refactoring and bug fixes in webkitpy. I don't even know much work is required for webkitperl and other tools.</div>
<div style><br></div><div style>- R. Niwa</div><div style><br></div></div></div></div>