<div dir="ltr">Hi Mario,<br><br>Thanks for your kind comments in detail.<br><br>I would be very thankful for you to do that work (using/maintaining this feature) for WebKitGTK+ port.<br>Of course, it helps to enhance first patch's quality.<br>
(Please keep my comment. "Copyright (C) 2013 Alticast Corporation. All rights reserved." with your comment.)<br><br>Ah, When I made a new patch, had doubts about the file name "Deprecated".<br>So, I have to wait the "StyleBuilder" Class to have a clear form.<br>
<br>Also, I'm waiting for the community to conclude this discussion.<br><br>-Kyounga<br><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/7/25 Mario Sanchez Prada <span dir="ltr"><<a href="mailto:mario.prada@samsung.com" target="_blank">mario.prada@samsung.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Kyounga,<br>
<br>
> [...]<br>
<div class="im">> First, I filed up my new patch based on the latest webkit without new<br>
feature-name even though this discussion wasn't concluded. <br>
<br>
</div>I did not find any patch in bugzilla for bug 66027 newer than the one from<br>
Jan 2012 when I started doing the experiments, so that's why I came up with<br>
my own rebased version. Now I see you posted a newer version already, thanks<br>
for doing that.<br>
<div class="im"><br>
> If you think this feature should be behind ENABLE_CSS_DIRECTIONAL_FOCUS,<br>
I'll make a new patch. <br>
<br>
</div>That's probably a good idea but first we need to clarify whether this might<br>
fit or not integrated in <a href="http://webkit.org" target="_blank">webkit.org</a>. And in order to do that, as Benjamin<br>
mentioned, we need to have at least one port using and maintaining that<br>
feature, so that's why I proposed that we could help doing that work for the<br>
WebKitGTK+ port, besides helping with the development of your patch, if you<br>
wish.<br>
<div class="im"><br>
> If this feature is widely used in TV industry and is included in next<br>
CSS4,<br>
> it is not bad implementing this feature in Webkit. Isn't it? <br>
<br>
</div>I agree with you, but for the feature to make it to upstream WebKit some<br>
more things are needed, as it was explained previously in this thread.<br>
<div class="im"><br>
> And then, should I mark the 66027 bug as "Reopended" to review it?<br>
<br>
</div>I would say so, but before asking for review over it, and besides the<br>
ongoing discussion here, I believe the patch needs still some changes in<br>
addition to being rebased, such as adding tests to it and probably<br>
re-writting the part based on the now called DeprecatedStyleBuilder which,<br>
according to r148363, should not be used to add new properties since a while<br>
ago.<br>
<br>
Thanks for your reply,<br>
Mario<br>
<br>
[1] <a href="http://trac.webkit.org/changeset/148363" target="_blank">http://trac.webkit.org/changeset/148363</a><br>
<div class="HOEnZb"><div class="h5"><br>
> -Kyounga<br>
><br>
> > 2013/7/25 Mario Sanchez Prada <<a href="mailto:mario.prada@samsung.com">mario.prada@samsung.com</a>><br>
> > Hi,<br>
> ><br>
> > For the sake of completeness, I'd like to mention that this feature is<br>
also<br>
> > used in the Hbbtv browser shipped with Samsung TVs, as Giuseppe Pascale<br>
from<br>
> > Opera already pointed out in a recent discussion[1].<br>
> ><br>
> > That, together with what it was mentioned about the SmartTV Alliance<br>
using<br>
> > it, means that pretty much the whole TV world is relying quite a bit on<br>
this<br>
> > thing nowadays, so it would be great if we could have it integrated and<br>
> > supported upstream.<br>
> ><br>
> > That being said, we at the Samsung would be happy to support this<br>
feature<br>
> > actively in WebKit, both by helping with the patch that's already in<br>
> > Bugzilla [2] *and* maintaining it in at least one port. Should that be<br>
the<br>
> > case, the obvious choice for us would be the WebKitGTK port, since<br>
that's<br>
> > what we currently have on our TVs.<br>
> ><br>
> > Problem is that the patch in [2] is quite old already (Jan 2012), so it<br>
> > would be awesome if Kyounga Ra attached a newer version of it, since<br>
that<br>
> > one depends on some parts that are now deprecated or simply refactored<br>
in<br>
> > some way, as I could check today while experimenting with it on top of<br>
> > latest WebKit [3].<br>
> ><br>
> > Last, regarding to tests, just to mention that Opera has recently<br>
submitted<br>
> > tests for this feature (see [4]). This would be IMHO another good point<br>
to<br>
> > keep in mind here, since we could import them in WebKit too.<br>
> ><br>
> > What do you think?<br>
> > Mario<br>
> ><br>
> > [1] <a href="http://lists.w3.org/Archives/Public/www-style/2013Jun/0332.html" target="_blank">http://lists.w3.org/Archives/Public/www-style/2013Jun/0332.html</a><br>
> > [2] <a href="https://bugs.webkit.org/show_bug.cgi?id=66027" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=66027</a><br>
> > [3]<br>
<a href="https://github.com/mariospr/webkit/commit/5bda577699599aa4f99192380b46ad73e5
ea1672" target="_blank">https://github.com/mariospr/webkit/commit/5bda577699599aa4f99192380b46ad73e5<br>
ea1672</a><br>
> > [4]<br>
<a href="http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html" target="_blank">http://lists.w3.org/Archives/Public/public-css-testsuite/2013Jul/0004.html</a><br>
><br>
> > -----Original Message-----<br>
> > From: <a href="mailto:webkit-dev-bounces@lists.webkit.org">webkit-dev-bounces@lists.webkit.org</a> [mailto:<a href="mailto:webkit-dev-">webkit-dev-</a><br>
> > <a href="mailto:bounces@lists.webkit.org">bounces@lists.webkit.org</a>] On Behalf Of Danilo Cesar Lemes de Paula<br>
> > Sent: 24 July 2013 14:52<br>
> > To: <a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
> > Subject: Re: [webkit-dev] Adding ENABLE_CSS_DIRECTIONAL_FOCUS to<br>
> > WebCore.<br>
> ><br>
> > On 07/23/2013 09:26 PM, Kyounga Ra wrote:<br>
> > > -Which browsers are shipping the feature?<br>
> > > -Which browsers are planning to ship the feature?<br>
> > > A) other major browsers? opera presto<br>
> > > also Webkit-based TV browsers support it.<br>
> > ><br>
> > > -Is it a mature standard (or an amazing feature) that one of the<br>
> > > WebKit ports wants to maintain?<br>
> > > A) not matured yet. but these properties are widely used by the TV<br>
> > > industry.<br>
> > > TV industry people like me want to maintain.<br>
> > ><br>
> ><br>
> > nav-[dir] is a required part of the SmartTV Alliance spec, so it's<br>
> > probably being used by Phillips, LG and Toshiba TVs.<br>
> ><br>
> > Danilo Cesar<br>
> ><br>
> > _______________________________________________<br>
> > webkit-dev mailing list<br>
> > <a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
> > <a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
<br>
<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
<br>
<br>
<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="https://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">https://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
</div></div></blockquote></div><br></div>