<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 13, 2013, at 9:48 AM, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org">rniwa@webkit.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On Wed, Mar 13, 2013 at 9:42 AM, Simon Fraser <span dir="ltr"><<a href="mailto:simon.fraser@apple.com" target="_blank">simon.fraser@apple.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><a href="https://bugs.webkit.org/show_bug.cgi?id=80046" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=80046</a> (landed in <a href="http://trac.webkit.org/changeset/114081" target="_blank">http://trac.webkit.org/changeset/114081</a>) added internals. setBackgroundBlurOnNode().<div>
<br></div><div>I consider this to be abuse of the Internals object. As shown by the location of the files (Source/WebCore/<b>testing</b>/Internals.*), the Internals interface is intended for testing, not adding API to toggle features in WebCore for non-test code.</div>
</div></blockquote><div><br></div><div>Sorry, I don't follow. <span style="background-color:rgb(255,255,255);color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px">setBackgroundBlurOnNode appears to be only called in a layout test as far as I read the patch. Where is this function called for non-testing purposes?</span></div>
</div></blockquote><br></div><div>Background blur (or background filters in general) are not a web-exposed feature, so it seems odd that Internals has a switch for some non-web-exposed feature that is only implemented by one port. It feels like this was something added for a UI feature in Chromium, in which case Internals isn't an appropriate way to toggle it.</div><div><br></div><div>Simon</div><div><br></div><br></body></html>