ah ok.<div><br><br><div class="gmail_quote">On Sat, Aug 18, 2012 at 10:06 PM, Tim Horton <span dir="ltr"><<a href="mailto:timothy_horton@apple.com" target="_blank">timothy_horton@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><br><div><div class="im"><div>On Aug 18, 2012, at 8:35 PM, Jake <<a href="mailto:jake@jakeonthenet.com" target="_blank">jake@jakeonthenet.com</a>> wrote:</div><br><blockquote type="cite">
Just a guess but shouldn't the #if line be:<div><br></div><div><span style="color:rgb(80,0,80);font-size:13px;font-family:arial,sans-serif">#if defined(ENABLE_CSS3_TEXT_</span><span style="color:rgb(80,0,80);font-size:13px;font-family:arial,sans-serif">DECORATION) && defined(ENABLE_CSS3_TEXT_DECORATION)</span><br>
</div></blockquote><div><br></div></div><div>No, this is supposed to be "if ENABLE_CSS3_TEXT_DECORATION is defined and it is defined to true". The line is correct as it stands.</div><div><div class="h5"><br><blockquote type="cite">
<div>-Jake</div><div><br></div><div><div class="gmail_quote">On Sat, Aug 18, 2012 at 8:20 PM, Tim Horton <span dir="ltr"><<a href="mailto:timothy_horton@apple.com" target="_blank">timothy_horton@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><br>
<br>
On Aug 17, 2012, at 11:57 AM, Bruno Abinader <<a href="mailto:brunoabinader@gmail.com" target="_blank">brunoabinader@gmail.com</a>> wrote:<br>
<br>
> On Fri, Aug 17, 2012 at 2:24 PM, Joe Mason <<a href="mailto:jmason@rim.com" target="_blank">jmason@rim.com</a>> wrote:<br>
>> What do you mean by "precompiler"? The preprocessor? Or is this a precompiled headers thing?<br>
><br>
> Indeed, s/precompiler/preprocessor :)<br>
><br>
>><br>
>> Are you sure there wasn't a typo in the "case CSSPropertyWebkitTextDecorationLine:" line which caused a perfectly normal syntax error when CSS3_TEXT_DECORATION was defined? Or maybe CSSPropertyWebkitTextDecorationLine was not defined?<br>
><br>
> There is no typo as far as I've checked. The following was added to<br>
> Source/WebCore/css/CSSPropertyNames.in:<br>
><br>
> ...<br>
> #if defined(ENABLE_CSS3_TEXT_DECORATION) && ENABLE_CSS3_TEXT_DECORATION<br>
> -webkit-text-decoration-line<br>
> #endif<br>
> ...<br>
><br>
>> I dislike this. Repeated code should be avoided. Fallthrough is a widely used and accepted technique to do that, ever since the days of C. I can't believe there's a compiler that doesn't handle this correctly.<br>
><br>
> +1 on that. I've re-checked the build bot output and it seems the<br>
> issue is actually caused because CSSPropertyWebkitTextDecorationLine<br>
> gets undefined. So I'm starting to believe the fail reason is<br>
> something else skipping from my eyes.<br>
<br>
</div>Without looking at the code, I vaguely think that CSSPropertyWebkitTextDecorationLine comes from a generated file that might not rebuild when it's supposed to. You should try a clean build and see -- there've been a few problems with this recently (I ran into it when switching flexbox and regions/exclusions on and off a lot a few months ago, and a colleague ran into it again recently in a similar situation).<br>
<div><div><br>
> The actual bug related to this<br>
> issue is <a href="https://bugs.webkit.org/show_bug.cgi?id=94108" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=94108</a> .<br>
><br>
>><br>
>>> Where each switch case is handled individually (if you're curious<br>
>>> about it, it is fixed in bug 90493). Said this, I would like to<br>
>><br>
>> <a href="https://bugs.webkit.org/show_bug.cgi?id=90493" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=90493</a> is "[chromium] Don't archive build files generated by VS2010", and doesn't seem to be related.<br>
><br>
> My bad :/ The right bug is 94093:<br>
> <a href="https://bugs.webkit.org/show_bug.cgi?id=94093" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=94093</a> .<br>
><br>
> --<br>
> Bruno de Oliveira Abinader<br>
> _______________________________________________<br>
> webkit-dev mailing list<br>
> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
> <a href="http://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
</div></div></blockquote></div><br></div>
</blockquote></div></div></div><br></div></blockquote></div><br></div>