On Thu, Aug 16, 2012 at 11:01 AM, Bruno Abinader <span dir="ltr"><<a href="mailto:brunoabinader@gmail.com" target="_blank">brunoabinader@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Thu, Aug 16, 2012 at 1:28 PM, Adam Barth <<a href="mailto:abarth@webkit.org">abarth@webkit.org</a>> wrote:<br>
> In that case, he might want to start with one port, get that working<br>
> well, and then expand to the other ports.<br>
><br>
> Adam<br>
<br>
</div>That's exactly what I am doing :) As I'm mostly familiar with Qt, it<br>
is the chosen platform were I am basing layout test results. I'm<br>
building and testing locally, both with and without the feature flag<br>
enabled, to make sure I'm not breaking any previous behavior. All new<br>
CSS3 text decorations are getting proper layout tests, and I am also<br>
taking care of editing feature, which I found proper spec already (<br>
<a href="https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html" target="_blank">https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html</a> ) and<br>
studying it. So far I just found basic text decoration support, so<br>
this is pretty well assured by current implementation.<br>
<div class="im"><br>
><br>
><br>
> On Thu, Aug 16, 2012 at 10:03 AM, Peter Beverloo <<a href="mailto:peter@chromium.org">peter@chromium.org</a>> wrote:<br>
>> It depends on the kind of feature you're working on, indeed.<br>
>><br>
>> While I don't know what Bruno's use-case is, In the case of text decoration,<br>
>> I guess it could involve testing the complex test code paths which can be<br>
>> different for port/platform combinations.<br>
<br>
</div>Indeed. So far there were no big changes between platforms (except<br>
pixel tests font size/type differences, for instance). But it's always<br>
good to be backed by EWS results to be sure everything's fine. I<br>
enjoyed your solution (to provide a separate patch to make EWS run the<br>
tests) which won't get landed, and that's what I'm going to do until<br>
we find a better solution. Thanks for the input!<br></blockquote><div><br></div><div>FYI, non-Chromium EWS don't run tests.</div><div><br></div><div>- Ryosuke</div><div><br></div></div>