Sure, that's fine.<div><br></div><div>But please make sure not to ship these CSS properties until editing code is properly fixed.<br><div><br></div><div><div class="gmail_quote">On Wed, Aug 1, 2012 at 4:47 AM, Bruno Abinader <span dir="ltr"><<a href="mailto:brunoabinader@gmail.com" target="_blank">brunoabinader@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Ryosuke,<br>
<br>
Indeed. On the proposed implementation I've assured that the original<br>
"text-decoration" from CSS 2.1 spec remains with exactly same behavior<br>
as before (though I've managed to get some shared code to avoid<br>
duplication). Layout tests results from my local run points no new<br>
failing tests due to these changes so far.<br>
<br>
As for the editing & execCommand, these will be handled later (you can<br>
see none of the patches touches any files inside<br>
Source/WebCore/editing directory). I know there are some management<br>
with CSSPropertyTextDecoration and<br>
CSSPropertyWebkitTextDecorationsInEffect going on there, but these<br>
stay untouched (in edting) until I acquire more information about<br>
-webkit-text-decorations-in-effect usage.<br>
<div class="HOEnZb"><div class="h5"><br>
On Tue, Jul 31, 2012 at 10:40 PM, Ryosuke Niwa <<a href="mailto:rniwa@webkit.org">rniwa@webkit.org</a>> wrote:<br>
> Please make sure the new text decoration values don't break editing (rich<br>
> text editing & execCommand). In particular, we probably need to update<br>
> ApplyStyleCommand/EditingStyle to handle -webkit-text-decoration*.<br>
><br>
> On Tue, Jul 31, 2012 at 7:35 PM, Bruno Abinader <<a href="mailto:brunoabinader@gmail.com">brunoabinader@gmail.com</a>><br>
> wrote:<br>
>><br>
>> Hi all :)<br>
>><br>
>> As suggested by Ojan, I am writing a mail to you about my intention to<br>
>> implement all updated and missing text-decoration* properties from<br>
>> CSS3 spec (currently in development), named below:<br>
>><br>
>> -webkit-text-decoration ( <a href="https://bugs.webkit.org/show_bug.cgi?id=92000" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=92000</a> )<br>
>> CSS3 dev spec: <a href="http://dev.w3.org/csswg/css3-text/#text-decoration" target="_blank">http://dev.w3.org/csswg/css3-text/#text-decoration</a><br>
>> Mozilla ref: <a href="https://developer.mozilla.org/en/CSS/text-decoration" target="_blank">https://developer.mozilla.org/en/CSS/text-decoration</a><br>
>> Status: Proposed patch / pending review<br>
>><br>
>> -webkit-text-decoration-line (<br>
>> <a href="https://bugs.webkit.org/show_bug.cgi?id=90959" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=90959</a> )<br>
>> CSS3 dev spec: <a href="http://dev.w3.org/csswg/css3-text/#text-decoration-line" target="_blank">http://dev.w3.org/csswg/css3-text/#text-decoration-line</a><br>
>> Mozilla ref: <a href="https://developer.mozilla.org/en/CSS/text-decoration-line" target="_blank">https://developer.mozilla.org/en/CSS/text-decoration-line</a><br>
>> Status: Proposed patch / pending review<br>
>><br>
>> -webkit-text-decoration-style (<br>
>> <a href="https://bugs.webkit.org/show_bug.cgi?id=90958" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=90958</a> )<br>
>> CSS3 dev spec: <a href="http://dev.w3.org/csswg/css3-text/#text-decoration-style" target="_blank">http://dev.w3.org/csswg/css3-text/#text-decoration-style</a><br>
>> Mozilla ref: <a href="https://developer.mozilla.org/en/CSS/text-decoration-style" target="_blank">https://developer.mozilla.org/en/CSS/text-decoration-style</a><br>
>> Status: Proposed patch / pending review<br>
>><br>
>> -webkit-text-decoration-color (<br>
>> <a href="https://bugs.webkit.org/show_bug.cgi?id=91638" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=91638</a> )<br>
>> CSS3 dev spec: <a href="http://dev.w3.org/csswg/css3-text/#text-decoration-color" target="_blank">http://dev.w3.org/csswg/css3-text/#text-decoration-color</a><br>
>> Mozilla ref: <a href="https://developer.mozilla.org/en/CSS/text-decoration-color" target="_blank">https://developer.mozilla.org/en/CSS/text-decoration-color</a><br>
>> Status: Proposed patch / pending review<br>
>><br>
>> -webkit-text-decoration-skip (<br>
>> <a href="https://bugs.webkit.org/show_bug.cgi?id=92801" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=92801</a> )<br>
>> CSS3 dev spec: <a href="http://dev.w3.org/csswg/css3-text/#text-decoration-skip" target="_blank">http://dev.w3.org/csswg/css3-text/#text-decoration-skip</a><br>
>> Status: Work in progress<br>
>><br>
>> As each patch touches similar places and sometimes requires previous<br>
>> work, this patch series requires the patches to be reviewed / commited<br>
>> in the same order as described above ( 92000, 90959, 90958, 91638 and<br>
>> 92801 ).<br>
>> The decision to use "-webkit-" prefix was suggested by Alexis on<br>
>> <a href="https://bugs.webkit.org/show_bug.cgi?id=90959#c13" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=90959#c13</a> . There is also a<br>
>> suggestion to use a specific flag to enable this feature at compile<br>
>> time, however other CSS3 properties such as text-emphasis, for<br>
>> example, do not use such flags, so I am a bit uncertain about it<br>
>> still.<br>
>><br>
>> I am really looking forward for comments and review on the proposed<br>
>> patches :)<br>
>><br>
>> Best regards,<br>
>><br>
>> --<br>
>> Bruno de Oliveira Abinader<br>
>> _______________________________________________<br>
>> webkit-dev mailing list<br>
>> <a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
>> <a href="http://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
><br>
><br>
<br>
<br>
<br>
--<br>
Bruno de Oliveira Abinader<br>
</div></div></blockquote></div><br></div></div>