On Fri, Jul 13, 2012 at 11:03 AM, Dana Jansens <span dir="ltr"><<a href="mailto:danakj@chromium.org" target="_blank">danakj@chromium.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_extra"><div class="gmail_quote"><div><div class="h5">On Fri, Jul 13, 2012 at 1:56 PM, Ryosuke Niwa <span dir="ltr"><<a href="mailto:rniwa@webkit.org" target="_blank">rniwa@webkit.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Fri, Jul 13, 2012 at 5:57 AM, Stephen Chenney <span dir="ltr"><<a href="mailto:schenney@chromium.org" target="_blank">schenney@chromium.org</a>></span> wrote:</div>
<div class="gmail_quote"><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote"><div><blockquote type="cite">
</blockquote></div><div>I don't doubt there are poor comments, both outdated and useless. That's a reviewing failure. You have simply highlighted the fact that any standard for comments requires reviewer attention. Hence "cost of maintaining comments".</div>
</div></blockquote><div><br></div></div><div>I don't know how to review a patch and make sure all relevant comments are updated.</div><div><br></div><div>As I have illustrated before, you can be modifying a function X, then a completely random function A which calls B that in turn calls C that in turns D ... that in turn calls X may have a comment dependent on the previous behavior of X without ever mentioning X. How am I supposed to know that there is such a comment?</div>
</div></blockquote><div><br></div></div></div><div>How is that different than the same question but replace "comment" with "behaviour"? In both cases A is no longer doing what it expected. Something is going to break, and A will have to be fixed/updated, comment included.</div>
</div></div></blockquote><div><br></div><div>Not necessarily. First off, the behavioral change may not have any user visible behavioral change, or that while X behaves differently, it doesn't affect the way A works due to some other changes in the same patch. Or it's possible that new behavior of A is expected and desirable but the change was made at much lower level and affected hundreds of other functions.</div>
<div><br></div><div>- Ryosuke</div><div><br></div></div>