<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I'd prefer we keep "Region" for the low-level graphics primitive Region (just like Path), and use something prefixed for the higher-level layout concept.<div><br></div><div>Simon</div><div><br><div><div>On Jul 12, 2012, at 10:26 AM, Dana Jansens wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote">On Thu, Jul 12, 2012 at 1:25 PM, Ryosuke Niwa <span dir="ltr"><<a href="mailto:rniwa@webkit.org" target="_blank" class="cremed">rniwa@webkit.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p>I'd vote for CSSRegion or CSSOMRegion for the class you're adding but I'll also suggest we rename the existing Region class now that the term "region" has a specific semantic in CSS. Maybe LayoutRegion or ScreenRegion?</p>
</blockquote><div>IntRegion? It seems closer to an IntRect than a LayoutRect. </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="HOEnZb"><font color="#888888"><p>- Ryosuke</p></font></span><div class="HOEnZb"><div class="h5">
<div class="gmail_quote">On Jul 12, 2012 10:13 AM, "Eric Seidel" <<a href="mailto:eric@webkit.org" target="_blank" class="cremed">eric@webkit.org</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I would go with CSSRegion, and stick it in the css/ folder. Much of<br>
the CSS folder is our implementation of the CSS Object Model (CSSOM).<br>
At some point it might make sense to pull all the classes which<br>
implement the CSSOM out of css/ into a new cssom/ similar to dom/, but<br>
that's a later discussion.<br>
<br>
-eric<br>
<br>
On Thu, Jul 12, 2012 at 10:03 AM, Andrei Bucur <<a href="mailto:abucur@adobe.com" target="_blank" class="cremed">abucur@adobe.com</a>> wrote:<br>
> From my knowledge the "CSS" prefix is reserved for the CSS engine classes in<br>
> WebKit. Prefixing the Region class with "CSS" could prove confusing.<br>
><br>
> Regards,<br>
> Andrei.<br>
><br>
> From: Alan Stearns <<a href="mailto:stearns@adobe.com" target="_blank" class="cremed">stearns@adobe.com</a>><br>
> Date: Thursday, July 12, 2012 7:39 PM<br>
> To: Adam Barth <<a href="mailto:abarth@webkit.org" target="_blank" class="cremed">abarth@webkit.org</a>>, Andrei Bucur <<a href="mailto:abucur@adobe.com" target="_blank" class="cremed">abucur@adobe.com</a>><br>
><br>
> Cc: "<a href="mailto:webkit-dev@lists.webkit.org" target="_blank" class="cremed">webkit-dev@lists.webkit.org</a>" <<a href="mailto:webkit-dev@lists.webkit.org" target="_blank" class="cremed">webkit-dev@lists.webkit.org</a>><br>
> Subject: Re: [webkit-dev] Web APIs and class name collisions<br>
><br>
> The spec itself consistently and deliberately calls them "CSS Regions," so a<br>
> CSS prefix could be appropriate.<br>
><br>
> Thanks,<br>
><br>
> Alan<br>
><br>
><br>
> From: Adam Barth <<a href="mailto:abarth@webkit.org" target="_blank" class="cremed">abarth@webkit.org</a>><br>
> To: Andrei Bucur <<a href="mailto:abucur@adobe.com" target="_blank" class="cremed">abucur@adobe.com</a>><br>
> Cc: "<a href="mailto:webkit-dev@lists.webkit.org" target="_blank" class="cremed">webkit-dev@lists.webkit.org</a>" <<a href="mailto:webkit-dev@lists.webkit.org" target="_blank" class="cremed">webkit-dev@lists.webkit.org</a>><br>
> Subject: Re: [webkit-dev] Web APIs and class name collisions<br>
><br>
> One common thing we do is prefix "DOM" to DOM-level concepts. For example,<br>
> DOMWindow and DOMFileSystem. I'm not sure if we have an established<br>
> convention for CSS-level concepts.<br>
><br>
> Adam<br>
><br>
><br>
> On Thu, Jul 12, 2012 at 9:18 AM, Andrei Bucur <<a href="mailto:abucur@adobe.com" target="_blank" class="cremed">abucur@adobe.com</a>> wrote:<br>
>><br>
>> Hello Webkittens!<br>
>><br>
>> While implementing the Region interface (<br>
>> <a href="http://dev.w3.org/csswg/css3-regions/#the-region-interface" target="_blank" class="cremed">http://dev.w3.org/csswg/css3-regions/#the-region-interface</a> ) I've noticed<br>
>> that the name "Region" is already taken by a class in platform/graphics. I'd<br>
>> like to know what's the best approach in these kind of situations:<br>
>><br>
>> Rename the existing WebCore class to something else and use the name<br>
>> "Region" for the Web API so there's parity between the implementation and<br>
>> the spec<br>
>> Somehow prefix the Web API implementation class name?<br>
>><br>
>> As the Web APIs expand I suppose this situation may occur again in the<br>
>> future and I suppose there should be a rule describing what's the best<br>
>> approach to take.<br>
>><br>
>> Thanks!<br>
>> Andrei.<br>
>><br>
>> _______________________________________________<br>
>> webkit-dev mailing list<br>
>> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank" class="cremed">webkit-dev@lists.webkit.org</a><br>
>> <a href="http://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank" class="cremed">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> webkit-dev mailing list<br>
> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank" class="cremed">webkit-dev@lists.webkit.org</a><br>
> <a href="http://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank" class="cremed">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
><br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank" class="cremed">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank" class="cremed">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
</blockquote></div>
</div></div><br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" class="cremed">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo/webkit-dev" target="_blank" class="cremed">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br>
<br></blockquote></div><br></div>
_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br><a href="http://lists.webkit.org/mailman/listinfo/webkit-dev">http://lists.webkit.org/mailman/listinfo/webkit-dev</a><br></blockquote></div><br></div></body></html>