Is the best way to do that to use run_webkit_tests to generate a new baseline or does Tools/Scripts/webkitpy/tool/commands/rebaseline.py support pulling new baselines from the trybots?<div><div><br></div><div>Thanks,</div>
<div>Tony</div><div><br><div class="gmail_quote">On Wed, Apr 11, 2012 at 2:13 PM, Ojan Vafai <span dir="ltr"><<a href="mailto:ojan@chromium.org">ojan@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Typically, if you're working on Chromium Linux or Win, you'd include the new expected results for that platform in your initial commit/code-review as well.<br><br><div class="gmail_quote"><div><div class="h5">On Wed, Apr 11, 2012 at 2:09 PM, Tony Payne <span dir="ltr"><<a href="mailto:tpayne@chromium.org" target="_blank">tpayne@chromium.org</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">All code I'm changing is inside of #if PLATFORM(CHROMIUM) blocks.<div><br></div><div>
Thanks for the quick answer.</div>
<span><font color="#888888"><div><br></div></font></span><div><span><font color="#888888">Tony</font></span><div><div><br><br><div class="gmail_quote">On Wed, Apr 11, 2012 at 2:03 PM, Ryosuke Niwa <span dir="ltr"><<a href="mailto:rniwa@webkit.org" target="_blank">rniwa@webkit.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div>On Wed, Apr 11, 2012 at 1:57 PM, Tony Payne <span dir="ltr"><<a href="mailto:tpayne@chromium.org" target="_blank">tpayne@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Given the recent discussion on test_expectations.txt, perhaps the answer to my question is still up in the air. <div><br></div><div>I'm working on a change that I expect to require changing the expectations for about 75 tests on chromium win and linux. <a href="https://trac.webkit.org/wiki/Rebaseline" target="_blank">https://trac.webkit.org/wiki/Rebaseline</a> seems to only cover the gardening work to rebaseline after the commit. I cannot find any wiki pages that describe what the original author is expected to do when making visual changes. Should I attempt to rebaseline manually? Should I mark the tests as failing? Should I just check in and let the bots go red?</div>
</blockquote><div><br></div></div><div>Just land the patch and rebaseline the tests. Please also coordinate with Chromium port's WebKit gardener when landing this patch.</div><div><br></div><div>Also, does this patch only affect Chromium Windows and Linux, and not GTK, Qt, Windows, etc...? If the answer is no, and will affect other non-Chromium ports, then you're also responsible for rebaselining or coordinating with other ports to make sure you don't break tests on their ports as well.</div>
<span><font color="#888888">
<div><br></div><div>- Ryosuke</div><div><br></div></font></span></div>
</blockquote></div><br></div></div></div>
<br></div></div>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br></blockquote></div><br>
</blockquote></div><br></div></div>