We have discussed this before: <a href="https://lists.webkit.org/pipermail/webkit-dev/2011-September/017868.html">https://lists.webkit.org/pipermail/webkit-dev/2011-September/017868.html</a><div><br></div><div>A better change would be for us to generate the diff on EWS, and get rid of binding tests step from build bots since they aren't really testing anything. The primary use case of run-bindings-tests is to see the diff before/after a code generator change and it has no business running on the bot or in check-webkit-style.</div>
<div><br></div><div>- Ryosuke<br><br><div class="gmail_quote">On Mon, Apr 9, 2012 at 6:39 AM, Vineet Chaudhary <span dir="ltr"><<a href="mailto:rgf748@motorola.com">rgf748@motorola.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><font face="arial, helvetica, sans-serif"><span style="border-collapse:collapse"><div style="margin-bottom:2em"><div><p style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px;font:normal normal normal 13px/normal Arial">
</p><p style="margin:0px 0px 0px 0px;font:13.0px Arial">Hi All,</p>
<p style="margin:0px 0px 0px 0px;font:13.0px Arial;min-height:15.0px"><br></p>
<p style="margin:0px 0px 0px 0px;font:13.0px Arial">It is observed that if changes are made in Codegenerator*.pm we need to rebase results of run-bindings-tests.</p>
<p style="margin:0px 0px 0px 0px;font:13.0px Arial">Many times authors forgot to update these binding results.</p><p style="margin:0px 0px 0px 0px;font:13.0px Arial"><br></p>
<p style="margin:0px 0px 0px 0px;font:13.0px Arial">IMO we should add check in ./check-webkit-style to warn/(give a chance) author to run run-bindings-tests if Codegenerator is modified.</p>
<p style="margin:0px 0px 0px 0px;font:13.0px Arial">I have filed bug for this <a href="https://bugs.webkit.org/show_bug.cgi?id=83354" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=83354</a> .</p>
<p style="margin:0px 0px 0px 0px;font:13.0px Arial;min-height:15.0px"><br></p>
<p style="margin:0px 0px 0px 0px;font:13.0px Arial">Please let me know if any suggestions to make this change.</p><div><br></div><div>Thanks,</div><div>Vineet</div><p></p></div></div></span></font></div>
<br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br></blockquote></div><br></div>