Ojan,<div><br></div><div>There are also quite a few files with the svn:executable property set (359 in LayoutTests alone, by my count), I think most of which are erroneous.</div><div><br></div><div>Philip<br><br><div class="gmail_quote">
On Thu, Mar 8, 2012 at 3:05 PM, Ojan Vafai <span dir="ltr"><<a href="mailto:ojan@chromium.org">ojan@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Whoops. A lot of these were from me yesterday. Sorry, I didn't realize I didn't have my subversion config set correctly.<div><br></div><div>I went to fix up my commits from yesterday and realized that a very large percentage of the pngs in the LayoutTests tree have the wrong svn:mime-type. Is anyone opposed to me doing a bulk fix for all the pngs?<div>
<br>find LayoutTests | grep \.png$ | grep -v \.svn | xargs svn ps svn:mime-type image/png</div><div><div class="h5"><div><br></div><div><br></div><div><br><div class="gmail_quote">On Thu, Mar 8, 2012 at 1:52 AM, Ashod Nakashian <span dir="ltr"><<a href="mailto:ashodnakashian@yahoo.com" target="_blank">ashodnakashian@yahoo.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div style="font-size:12pt;font-family:arial,helvetica,sans-serif"><div><span>Please let's also enforce svn:eol-style to LF for all scripts as this is breaking (at least) the bash scripts that are checked-out with native style on Windows. Some bash versions don't like CR. </span><span style="font-size:12pt">Please see a (failed) attempt at fixing this manually[1].</span></div>
<div><span style="font-size:12pt"><br></span></div><div><span style="font-size:12pt">I also believe we should mark all (Bash/Perl/Python) scripts as executable.</span><span style="font-size:12pt"> It's best to at least automate it, if not also check for violations via check-webkit-style. (And for the loving of all that's good, would someone please help with this bug[1]?)</span></div>
<div><span><br></span></div><div><span>[1] </span><a href="https://bugs.webkit.org/show_bug.cgi?id=79509" style="font-size:12pt" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=79509</a></div><div><span><br></span></div>
<div><span style="font-size:12pt">-Ash</span><br></div><div><br><blockquote style="border-left:2px solid rgb(16,16,255);margin-left:5px;margin-top:5px;padding-left:5px"> <div style="font-size:12pt;font-family:arial,helvetica,sans-serif">
<div style="font-size:12pt;font-family:'times new roman','new york',times,serif"> <div dir="ltr"> <font face="Arial"> <hr size="1"> <b><span style="font-weight:bold">From:</span></b> Simon Fraser <<a href="mailto:simon.fraser@apple.com" target="_blank">simon.fraser@apple.com</a>><br>
<b><span style="font-weight:bold">To:</span></b> Eric Seidel <<a href="mailto:eric@webkit.org" target="_blank">eric@webkit.org</a>> <br><b><span style="font-weight:bold">Cc:</span></b> WebKit Development <<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a>> <br>
<b><span style="font-weight:bold">Sent:</span></b> Thursday, March 8, 2012 3:37 AM<br> <b><span style="font-weight:bold">Subject:</span></b> Re: [webkit-dev]
Please set the svn:mime-type property on binary files before committing<br> </font> </div><div><div> <br>
The best way to enforce it would be with a pre-commit hook:<br><<a href="https://bugs.webkit.org/show_bug.cgi?id=80548" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=80548</a>><br><br>Simon<br><br>On Mar 7, 2012, at 3:33 PM, Eric Seidel wrote:<br>
<br>> Unless this is enforced by a tool, it's very likely to be forgotten.<br>> <br>> <a href="https://bugs.webkit.org/show_bug.cgi?id=75824" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=75824</a><br>
> <a href="https://bugs.webkit.org/show_bug.cgi?id=75825" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=75825</a><br>> <br>> <br>> On Wed, Mar 7, 2012 at 3:21 PM, Dan Bernstein <<a href="mailto:mitz@apple.com" target="_blank">mitz@apple.com</a>> wrote:<br>
>> Please set the svn:mime-type property on binary files that you add to the<br>>> tree, such as *-expected.png, before committing. Otherwise the resulting<br>>>
webkit-changes message will include those files as text, which is<br>>> inconvenient.<br>>> <br>>> Thanks.<br>>> <br>>> _______________________________________________<br>>> webkit-dev mailing list<br>
>> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>>> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
>> <br>> _______________________________________________<br>> webkit-dev mailing list<br>> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br>_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br><a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br><br> </div></div></div> </div> </blockquote></div> </div></div>
<br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br></blockquote></div><br></div></div></div></div>
<br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br></blockquote></div><br></div>