<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div>I'd prefer we not modify imported test suites. That will just make it more confusing to update. Perhaps future CSS test suites will be changed to a reftest model.<div><br></div><div>Regards,</div><div>Maciej<br><div><br><div><div>On Mar 7, 2012, at 1:41 PM, Ojan Vafai wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">I just did a first pass a greening the Chromium Lion bot: <a href="http://trac.webkit.org/changeset/110096">http://trac.webkit.org/changeset/110096</a>. Of these hundreds of tests, ~99% of them are perfect candidates for being reftests (e.g. they contain one line of text and a solid box or two under the text), but most of them are in the CSS imported test suites.<div>
<br></div><div>Is it kosher to convert them to reftests or should we leave pixel tests from imported test suites alone?</div>
_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev<br></blockquote></div><br></div></div></body></html>