<br><br><div class="gmail_quote">On Wed, Jan 4, 2012 at 3:39 PM, Elliot Poger <span dir="ltr"><<a href="mailto:epoger@chromium.org">epoger@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
What is it that causes some tests to require baseline images (and not text files) for comparison, while others require text and not image baselines?<div><br></div><div>(I know that I can specifically SKIP comparison against IMAGE and/or TEXT using test_expectations.txt... but even without the use of test_expectations, I believe that some tests are compared against only text or only image.)<br>


<div><br></div><div>As an example, I see that this test has only image baselines and no text baselines:</div><div><br></div><div><div><div>$ ls LayoutTests/platform/*/fast/canvas/canvas-text-baseline*.png | wc -l</div><div>


10</div><div>$ ls LayoutTests/platform/*/fast/canvas/canvas-text-baseline*.txt | wc -l</div><div>ls: cannot access LayoutTests/platform/*/fast/canvas/canvas-text-baseline*.txt: No such file or directory </div></div></div>
</div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div><div>0</div></div></div></div></blockquote><div><br></div><div>Wrong, you've missed some:</div>
<div><br></div><div> $ find LayoutTests/ -name canvas-text-baseline*</div><div>LayoutTests/platform/chromium-linux/fast/canvas/canvas-text-baseline-expected.png</div><div>LayoutTests/platform/gtk/fast/canvas/canvas-text-baseline-expected.png</div>
<div>LayoutTests/platform/qt/fast/canvas/canvas-text-baseline-expected.png</div><div>LayoutTests/platform/efl/fast/canvas/canvas-text-baseline-expected.png</div><div>LayoutTests/platform/chromium-win/fast/canvas/canvas-text-baseline-expected.png</div>
<div>LayoutTests/platform/chromium-gpu-linux/fast/canvas/canvas-text-baseline-expected.png</div><div>LayoutTests/platform/chromium-gpu-win/fast/canvas/canvas-text-baseline-expected.png</div><div>LayoutTests/platform/mac/fast/canvas/canvas-text-baseline-expected.png</div>
<div>LayoutTests/fast/canvas/canvas-text-baseline.html</div><div>LayoutTests/fast/canvas/canvas-text-baseline-expected.txt <-------- this one applies</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div><div>
</div>
<div><br></div><div>while this test has only text baselines and no image baselines:</div><div><br></div><div><div>$ ls LayoutTests/platform/*/fast/canvas/canvas-lineWidth*.png | wc -l</div><div>ls: cannot access LayoutTests/platform/*/fast/canvas/canvas-lineWidth*.png: No such file or directory</div>


<div>0</div><div>$ ls LayoutTests/platform/*/fast/canvas/canvas-lineWidth*.txt | wc -l</div><div>5</div></div></div></div></blockquote><div><br></div><div>This test calls layoutTestController.dumpAsText() (in js-test-pre.js), so there's no .png.</div>
<div><br></div><div>- James </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div><br></div><div>Is there something inherent in each test that indicates whether its results will be compared against image and/or text baselines?  Or is it simply a matter of what baseline files are found to compare against?</div>


</div></div><div><br></div>
<br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br></blockquote></div><br>