Personally, I like this pattern a lot.<br><br>Would it also be helpful when sheriff bot rolls out a patch to attach the rolled out patch with a nice description like ROLLOUT(rXXXXX) to the bug? <br><br><div class="gmail_quote">
On Sun, Jun 19, 2011 at 8:36 PM, Eric Seidel <span dir="ltr"><<a href="mailto:eric@webkit.org" target="_blank">eric@webkit.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On Sun, Jun 19, 2011 at 11:31 AM, Darin Adler <<a href="mailto:darin@apple.com" target="_blank">darin@apple.com</a>> wrote:<br>
> On Jun 18, 2011, at 9:01 PM, Antonio Gomes wrote:<br>
><br>
>> I actually do not like the way the review flags are cleared today only in order to make the tools and pending-xxx pages happier. IMO the review flags give much about the history of the bug. In that matter, I dislike webkit-patch's ways of clearing "r-" flags of patches while it marks it as obsolete and uploads a new one. Reason: an easy-to-see r-'ed patch is very helpful to me to understand the chronological progresses in the bug.<br>
><br>
> I agree that it would be clearer to leave review flags for clarity about the history of a patch. I also have been irritated by our work flow that involves clearing review flags to appease the tools.<br>
><br>
> However, even if we fixed everything so that was no longer necessary, I would still want a way to clearly communicate “this patch is known to be bad and not suitable for landing, despite the fact that a reviewer approved it at one point”.<br>
><br>
> And I also think that if we were redesigning the bug system it would be good if there was a way to communicate that a patch was landed other than having a bug marked RESOLVED, because people continue to put multiple patches in a single bug, and so the bugs state can’t really tell us the status of a patch.<br>
<br>
</div>I'm happy to change webkit-patch to change the descriptions on patches<br>
to prefix "LANDED(r12354):" when landing/obsoleting, etc. if you think<br>
that would help.<br>
<font color="#888888"><br>
-eric<br>
</font><div><div></div><div><br>
> -- Darin<br>
><br>
> _______________________________________________<br>
> webkit-dev mailing list<br>
> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
><br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>--Antonio Gomes<br>