<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"><title>Re: [webkit-dev] Adding CSS Regions and Exclusions to WebKit</title>
</head>
<body>
<font face="Verdana, Helvetica, Arial"><span style="font-size:11pt">On 5/26/11 3:08 PM, "David Hyatt" <<a href="hyatt@apple.com">hyatt@apple.com</a>> wrote:<br>
<br>
</span></font><blockquote><font face="Verdana, Helvetica, Arial"><span style="font-size:11pt">On May 26, 2011, at 4:31 PM, Eric Seidel wrote:<br>
<br>
</span></font><blockquote><font face="Verdana, Helvetica, Arial"><span style="font-size:11pt">I appreciate that you've followed the master-bug idiom which is so common in bugs.webkit.org <<a href="http://bugs.webkit.org/">http://bugs.webkit.org/</a>> these days!<br>
<br>
I also would *strongly* encourage you to post your changes in as small of patches as possible. Integrating features which have been developed outside webkit.org <<a href="http://webkit.org/">http://webkit.org/</a>> is always difficult, but doing things in small (or even tiny!) patches will make your life easiest in the long run.<br>
<br>
I'm happy to help review your (small!) changes if CC'd.<br>
</span></font></blockquote><font face="Verdana, Helvetica, Arial"><span style="font-size:11pt"><br>
I've encouraged them to begin with the CSS property back end, i.e., getting the new properties and values in and parsed. I think it will be a good introduction to our process to start there, and it will also let them get familiar with writing regression tests. I think those patches are more easily reviewed by many people as well, unlike the layout and rendering changes, which are quite advanced.<br>
<br>
</span></font></blockquote><font face="Verdana, Helvetica, Arial"><span style="font-size:11pt">Following this advice, we’re preparing some initial patches that only contain the parsing code. I have been looking for pure parsing tests to use as examples for the tests we will need to submit with these patches, but I haven’t yet found anything to go on. I’m guessing that I’m not looking in the right place, or (for those who have followed this patch trajectory before) initial parsing tests get replaced with functional tests over time.<br>
<br>
Does anyone have an example of good parsing validation they can point me to?<br>
<br>
Thanks,<br>
<br>
Alan</span></font>
</body>
</html>