I think more important issue to consider is should WebKit unit-tests (TestWebKitAPI) live under Tools. <div>Unit-tests evolve with the product and an organic part of it - it doesn't feel that they constitute a "tool".</div>
<div><br></div><div>Three possible locations come to mind:</div><div>- ./Tests - separate top-level directory, sibling to Source and LayoutTests</div><div>- ./Source/Test - separate directory, but under Source to emphasize that tests are part of the source code</div>
<div>- Scattered around by the files that tests test, as David suggests.</div><div><br></div><div>In terms of gtest directory placement, I think it is nice to have all third-party libraries live in the same place.</div><div>
<br></div><div>What do people think?</div><div><br></div><div>Kind regards,</div><div>Dmitry<br><br><div class="gmail_quote">On Thu, May 12, 2011 at 9:38 AM, David Levin <span dir="ltr"><<a href="mailto:levin@chromium.org" target="_blank">levin@chromium.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>It sounds like you have a helpful mental mapping for what belongs in each directory that we haven't written anywhere. Perhaps you could write it down and send it to webkit-dev so that we can make it a common model.</div>
<div><br></div><div>It feels like a related topic is why are the unit tests under Tools as opposed to being by the files that they test. Being by the files they tests would make them easier to find and change as needed. (For an example of where this is done, see <a href="http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common" target="_blank">http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common</a> where there is file.py and file_unittest.py)</div>
<div><br></div><div>dave<div><div></div><div><br><br><div class="gmail_quote">On Thu, May 12, 2011 at 8:36 AM, Dan Bernstein <span dir="ltr"><<a href="mailto:mitz@apple.com" target="_blank">mitz@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Is gtest required to build any of the WebKit ports? If not, can it be moved out of Source and into Tools?<br>
<br>
Thanks,<br>
—Dan<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</blockquote></div><br></div></div></div>
<br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br></blockquote></div><br>
</div>