<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On 2010-12-22, at 10:19, Adam Barth wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Wed, Dec 22, 2010 at 9:37 AM, Kenneth Russell <<a href="mailto:kbr@google.com">kbr@google.com</a>> wrote:<br><blockquote type="cite">On Tue, Dec 21, 2010 at 11:40 PM, Adam Barth <<a href="mailto:abarth@webkit.org">abarth@webkit.org</a>> wrote:<br></blockquote><blockquote type="cite"><blockquote type="cite">On Tue, Dec 21, 2010 at 11:30 PM, Darin Adler <<a href="mailto:darin@apple.com">darin@apple.com</a>> wrote:<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">On Dec 21, 2010, at 11:20 PM, Adam Barth wrote:<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">Looking through my working copy, there are a couple of things that aren't obvious to me where they would go in this structure: WebKitBuild and WebKitLibraries. Maybe these would become Build and Libraries as top-level directories?<br></blockquote></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">WebKitBuild is a builds and intermediates directory for Xcode, specific to Mac. It’s set up by the WebKit project build scripts for people who don’t have Xcode set to use a particular build directory, because the WebKit projects need to build into a single build directory. I don’t have one of those on my computer because I do have WebKit set to use a single builds and intermediates directory (in my case ~/Build). I don’t know the right answer for what to do about this. We just need a sensible default for people building on Mac. Maybe calling it just Build and leaving it at the top level would be fine.<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><blockquote type="cite">WebKitLibraries contains libraries and header files needed to build WebKit on Mac and Windows. The name Libraries would be OK for those things; I’m not sure it’s optimal.<br></blockquote></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">What about ANGLE? My understanding is that ANGLE is third-party code<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">that we have checked into the tree but that we're not supposed to<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">modify. Should that go in Sources or in Libraries? In Chrome,<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">similar things are placed in a ThirdParty directory to remind folks<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">not to modify them.<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">Since ANGLE was first checked in to WebKit, a WebCore/thirdparty<br></blockquote><blockquote type="cite">directory was added. It would make most sense to move ANGLE into it.<br></blockquote><br>That sounds worth doing independently of whether we do the rest of the<br>re-organization. Would you be willing to move the directory, or would<br>you prefer I move it?<br></div></blockquote></div><br><div>Moving ANGLE inside WebCore seems backwards. ANGLE is not part of WebCore, it's a dependency of WebCore. If we want to introduce a directory for third-party libraries then I think that's reasonable. However, I don't think such a directory should live inside WebCore.</div><div><br></div><div>- Mark</div><div><br></div></body></html>