<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 21, 2010, at 11:39 AM, Darin Fisher wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">I'm working on fixing some session history bugs related to a HistoryItem's URL property changing.<div>See for example the call to HistoryItem::setURL in HistoryController::updateForReload [1].<br><div><br></div><div>
I'm curious about the platform specific fields on WebCore::HistoryItem. *** Do any of those need to</div><div>be updated when the URL of the HistoryItem changes? ***</div><div><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#144FAE"><br></font></font></div></div></blockquote><blockquote type="cite"><div><div>Here are the fields I'm referring to:</div>
<div><br></div><div>class HistoryItem ... {</div><div>private:</div><div> ...</div><div><div>#if PLATFORM(MAC)</div><div> RetainPtr<id> m_viewState;</div></div></div></blockquote><div><br></div>This is used for the Page Cache only. The URL had sure better not change while the page is cached!</div><div><br></div><div><blockquote type="cite"><div><div><div> OwnPtr<HashMap<String, RetainPtr<id> > > m_transientProperties;</div></div></div></blockquote><div><br></div>This is to support arbitrary WebKit Mac API and has nothing to do with the URL identity of the item.</div><div><br></div><div>~Brady</div><div><br></div></body></html>