<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Dec 21, 2010, at 1:57 PM, Darin Fisher wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br><br><div class="gmail_quote">On Tue, Dec 21, 2010 at 11:49 AM, Darin Fisher <span dir="ltr"><<a href="mailto:darin@chromium.org">darin@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br><br><div class="gmail_quote"><div class="im">On Tue, Dec 21, 2010 at 11:46 AM, Brady Eidson <span dir="ltr"><<a href="mailto:beidson@apple.com" target="_blank">beidson@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><br><div><div><div>On Dec 21, 2010, at 11:39 AM, Darin Fisher wrote:</div><br><blockquote type="cite">I'm working on fixing some session history bugs related to a HistoryItem's URL property changing.<div>
See for example the call to HistoryItem::setURL in HistoryController::updateForReload [1].<br><div><br></div><div>
I'm curious about the platform specific fields on WebCore::HistoryItem. *** Do any of those need to</div><div>be updated when the URL of the HistoryItem changes? ***</div><div><font color="#000000"><font color="#144FAE"><br>
</font></font></div></div></blockquote><blockquote type="cite"><div><div>Here are the fields I'm referring to:</div>
<div><br></div><div>class HistoryItem ... {</div><div>private:</div><div> ...</div><div><div>#if PLATFORM(MAC)</div><div> RetainPtr<id> m_viewState;</div></div></div></blockquote><div><br></div></div>This is used for the Page Cache only. The URL had sure better not change while the page is cached!</div>
</div></blockquote><div><br></div></div><div>OK, I will assert that it is 0.</div><div class="im"><div><br></div></div></div></blockquote><div><br></div><div>Awesome, I found a layout test where the URL of the HistoryItem changes, and there is an associated cached page for the HistoryItem! I presume the right fix is to clear the cached page.</div></div></blockquote><div><br></div>No no no!!!</div><div><br></div><div>Why is anyone trying to do anything to the URL of an item that represents a cached page???</div><div><br><blockquote type="cite"><div class="gmail_quote">
<div>In case you are interested, the layout test where this happens is: fast/history/timed-refresh-in-cached-frame.html</div></div></blockquote><div><br></div>Shouldn't the timed refresh be paused while the page is cached, and only resume once the page is brought out?</div><div><br></div><div>In other words, should the URL only be changed after the page is restored?</div><div><br></div><div>~Brady<br><br><blockquote type="cite"><div class="gmail_quote"><div><br></div><div>-Darin</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="gmail_quote"><div class="im"><div></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">
<div><br></div><div><div><blockquote type="cite"><div><div><div> OwnPtr<HashMap<String, RetainPtr<id> > > m_transientProperties;</div></div></div></blockquote><div><br></div></div>This is to support arbitrary WebKit Mac API and has nothing to do with the URL identity of the item.</div>
</div></blockquote><div><br></div></div><div>OK, thanks!</div><div><br></div><font color="#888888"><div>-Darin</div></font></div>
</blockquote></div><br>
</blockquote></div><br></body></html>