I frequently copy & paste function names, variable names, etc... into my comment so I like the new behavior.<div><br></div><div>- Ryosuke<br><br><div class="gmail_quote">On Wed, Nov 10, 2010 at 10:18 AM, Adam Barth <span dir="ltr"><<a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yeah, Darin and Alexey asked for this change. I thought about<br>
emailing webkit-dev, but I was worried that would have been too spamy.<br>
Hopefully the new behavior works for everyone.<br>
<br>
Adam<br>
<div><div></div><div><br>
<br>
On Wed, Nov 10, 2010 at 6:36 AM, David Levin <<a href="mailto:levin@chromium.org" target="_blank">levin@chromium.org</a>> wrote:<br>
> (Single) Click on the line numbers to leave comments. Not the lines in the<br>
> code review.<br>
> I'm just pointing this out because I only just noticed and thought it was<br>
> broken when I couldn't double click lines. (There is text at the top of the<br>
> page but I claim to have banner blindness.)<br>
> dave<br>
><br>
> ---------- Forwarded message ----------<br>
> From: <<a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a>><br>
> Date: Mon, Nov 8, 2010 at 2:18 PM<br>
> Subject: [webkit-changes] [71570] trunk/BugsSite<br>
> To: <a href="mailto:webkit-changes@lists.webkit.org" target="_blank">webkit-changes@lists.webkit.org</a><br>
><br>
><br>
> Revision 71570 Author <a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a> Date 2010-11-08 14:18:05 -0800 (Mon,<br>
> 08 Nov 2010)<br>
><br>
> Log Message<br>
><br>
> 2010-11-08 Adam Barth <<a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a>><br>
><br>
> Reviewed by Eric Seidel.<br>
><br>
> Restore normal meaning of double-click on patch review page?<br>
> <a href="https://bugs.webkit.org/show_bug.cgi?id=47641" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=47641</a><br>
><br>
> After this patch, you need to click on the line numbers to add a<br>
> comment.<br>
><br>
> * PrettyPatch/PrettyPatch.rb:<br>
> * code-review.js:<br>
><br>
> Modified Paths<br>
><br>
> trunk/BugsSite/ChangeLog<br>
> trunk/BugsSite/PrettyPatch/PrettyPatch.rb<br>
> trunk/BugsSite/code-review.js<br>
><br>
> Diff<br>
><br>
> Modified: trunk/BugsSite/ChangeLog (71569 => 71570)<br>
><br>
> --- trunk/BugsSite/ChangeLog 2010-11-08 22:10:51 UTC (rev 71569)<br>
> +++ trunk/BugsSite/ChangeLog 2010-11-08 22:18:05 UTC (rev 71570)<br>
> @@ -1,3 +1,16 @@<br>
> +2010-11-08 Adam Barth <<a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a>><br>
> +<br>
> + Reviewed by Eric Seidel.<br>
> +<br>
> + Restore normal meaning of double-click on patch review page?<br>
> + <a href="https://bugs.webkit.org/show_bug.cgi?id=47641" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=47641</a><br>
> +<br>
> + After this patch, you need to click on the line numbers to add a<br>
> + comment.<br>
> +<br>
> + * PrettyPatch/PrettyPatch.rb:<br>
> + * code-review.js:<br>
> +<br>
> 2010-10-09 Adam Barth <<a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a>><br>
><br>
> Reviewed by Alexey Proskuryakov.<br>
><br>
> Modified: trunk/BugsSite/PrettyPatch/PrettyPatch.rb (71569 => 71570)<br>
><br>
> --- trunk/BugsSite/PrettyPatch/PrettyPatch.rb 2010-11-08 22:10:51 UTC (rev<br>
> 71569)<br>
> +++ trunk/BugsSite/PrettyPatch/PrettyPatch.rb 2010-11-08 22:18:05 UTC (rev<br>
> 71570)<br>
> @@ -312,7 +312,7 @@<br>
> }<br>
> </style><br>
> <script<br>
> src="<a href="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js" target="_blank">https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js</a>"></script><br>
> -<script src="code-review.js?version=13"></script><br>
> +<script src="code-review.js?version=14"></script><br>
> EOF<br>
><br>
> def self.revisionOrDescription(string)<br>
><br>
> Modified: trunk/BugsSite/code-review.js (71569 => 71570)<br>
><br>
> --- trunk/BugsSite/code-review.js 2010-11-08 22:10:51 UTC (rev 71569)<br>
> +++ trunk/BugsSite/code-review.js 2010-11-08 22:18:05 UTC (rev 71570)<br>
> @@ -253,7 +253,7 @@<br>
> }<br>
><br>
> function crawlDiff() {<br>
> - $('.Line').each(idify).each(hoverify).dblclick(addCommentField);<br>
> + $('.Line').each(idify).each(hoverify);<br>
> $('.FileDiff').each(function() {<br>
> var file_name = $(this).children('h1').text();<br>
> files[file_name] = this;<br>
><br>
> _______________________________________________<br>
> webkit-changes mailing list<br>
> <a href="mailto:webkit-changes@lists.webkit.org" target="_blank">webkit-changes@lists.webkit.org</a><br>
> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes</a><br>
><br>
><br>
><br>
</div></div>> _______________________________________________<br>
> webkit-dev mailing list<br>
> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
><br>
><br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</blockquote></div><br></div>