<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 1, 2010, at 10:00 AM, David Hyatt wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Yeah I agree with Peter. I think blank lines after { and before } would improve the readability of the 2nd example even without indentation.<div><br></div><div><span class="Apple-style-span" style="font-family: Courier; ">namespace WebCore {</span></div><div><span class="Apple-style-span" style="font-family: Courier; "></span><span class="Apple-style-span" style="font-family: Courier; "><br></span><span class="Apple-style-span" style="font-family: Courier; ">class AuthenticationChallenge;</span><span class="Apple-style-span" style="font-family: Courier; "><br></span><span class="Apple-style-span" style="font-family: Courier; ">class CachedFrame;</span><span class="Apple-style-span" style="font-family: Courier; "><br></span><span class="Apple-style-span" style="font-family: Courier; ">class HistoryItem;</span><span class="Apple-style-span" style="font-family: Courier; "><br></span><span class="Apple-style-span" style="font-family: Courier; ">class ProtectionSpace;</span><span class="Apple-style-span" style="font-family: Courier; "><br></span><span class="Apple-style-span" style="font-family: Courier; ">class ResourceLoader;</span><span class="Apple-style-span" style="font-family: Courier; "><br></span><span class="Apple-style-span" style="font-family: Courier; ">class ResourceRequest;</span><span class="Apple-style-span" style="font-family: Courier; "><br></span><span class="Apple-style-span" style="font-family: Courier; "><br></span></div><div><span class="Apple-style-span" style="font-family: Courier; ">}</span></div></div></blockquote><div><br></div>I agree this also makes it more readable, but...</div><div><br><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>This doesn't seem worth making a special case for to me.</div></div></blockquote><div><br></div>If the general sentiment is "I don't have a strong preference either way", then I would argue that we should allow its continued used simply because so much code already uses it.</div><div><br></div><div>~Brady</div><div><br><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div><div>dave</div><div>(<a href="mailto:hyatt@apple.com">hyatt@apple.com</a>)</div><div><br></div><div><div><div>On Nov 1, 2010, at 11:49 AM, Peter Kasting wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On Mon, Nov 1, 2010 at 9:40 AM, Brady Eidson <span dir="ltr"><<a href="mailto:beidson@apple.com">beidson@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word"><div>I think this pattern increases readability of forward declarations in headers and we should change the style guidelines to specify its continued use.</div><div><br></div><div>Thoughts?</div>
</div></blockquote><div><br></div><div>I don't find either one significantly better than the other, personally.</div><div><br></div><div>PK </div></div>
_______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br><a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br></blockquote></div><br></div></div></blockquote></div><br></body></html>