This matches Chromium's desired behavior and is only a change for Chromium Linux. So, no objections there.<br><br><div class="gmail_quote">On Wed, Oct 27, 2010 at 2:17 PM, Antonio Gomes <span dir="ltr"><<a href="mailto:tonikitoo@gmail.com">tonikitoo@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi.<br>
<br>
In bug <a href="https://bugs.webkit.org/show_bug.cgi?id=36627" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=36627</a> (Needs a<br>
"LinuxEditingBehavior", perhaps with a better name) , in order to<br>
supply needs that the existing editing behaviors (Mac and Windows) do<br>
not cover, we are going to add a new editing behavior type. The name<br>
is not defined yet, and our current options are LinuxEditingBehavior,<br>
EditingUnixBehavior, EditingFreedesktopOrgBehavior,<br>
EditingFreedesktopBehavior or EditingXWindowsBehavior.<br>
<br>
Well, despite the naming to be used, in the same bug I am proposing<br>
that the editing behavior of each platform to be set according to the<br>
OS it is running on. As an example, Chromium when built on Mac would<br>
have the MacEditingBehavior set, while when built on Windows it would<br>
have the Window editing behavior, etc. The same logic would apply to<br>
all cross-platform ports, including QtWebKit. On the other hand, OS<br>
specific ports like Apple's Mac and Windows ports would not have to<br>
worry about it, since they just run on Mac or Windows respectively.<br>
<br>
static EditingBehaviorType editingBehaviorTypeForPlatform()<br>
{<br>
return<br>
#if OS(DARWIN)<br>
EditingMacBehavior<br>
#elif OS(WINDOWS)<br>
EditingWindowsBehavior<br>
#elif OS(UNIX)<br>
EditingLinuxBehavior<br>
#else<br>
// Fallback<br>
EditingMacBehavior<br>
#endif<br>
;<br>
}<br>
<br>
Before anything I would like to point it our here, and hear from the<br>
port maintainers any possible objection about it, specially from the<br>
cross-platform ones, including Chromium and Qt.<br>
<font color="#888888"><br>
--<br>
--Antonio Gomes<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</font></blockquote></div><br>