On Fri, Oct 1, 2010 at 12:03, Adam Barth <span dir="ltr"><<a href="mailto:abarth@webkit.org">abarth@webkit.org</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<a href="https://bugs.webkit.org/show_bug.cgi?id=46956" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=46956</a><br>
<br>
Unfortunately, it doesn't solve the whole problem. It does seem to<br>
reduce the flakiness by a lot though.<br></blockquote><div><br></div><div>Thanks!</div><div><br></div><div>I think it might be race between DRT and pywebsocekt server, that is, DRT tries to run tests while pywebsocket server is still initializing and not yet ready to serve html. I'll try to fix pywebsocket to reduce initialization latency.</div>
<div><br></div><div>-- </div><div>ukai</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<font color="#888888"><br>
Adam<br>
</font><div><div></div><div class="h5"><br>
<br>
On Thu, Sep 30, 2010 at 6:12 PM, Adam Barth <<a href="mailto:abarth@webkit.org">abarth@webkit.org</a>> wrote:<br>
> Currently the WebSocket tests are served over HTTP from the WebSocket<br>
> server itself (which is written in Python). It looks like we can<br>
> resolve the flakiness by serving the WebSocket tests from the normal<br>
> Apache server that servers the rest of our HTTP tests. I'm going to<br>
> work up a patch that does that. Please let me know if there's any<br>
> reason we shouldn't make that change.<br>
><br>
> Thanks,<br>
> Adam<br>
><br>
><br>
> On Thu, Sep 30, 2010 at 3:10 PM, Adam Barth <<a href="mailto:abarth@webkit.org">abarth@webkit.org</a>> wrote:<br>
>> I'm investigating the websocket issue. It seems these tests are flaky<br>
>> because they time out. If you know about websockets, I'd appreciate<br>
>> any tips you have via #webkit.<br>
>><br>
>> Adam<br>
>><br>
>><br>
>> On Wed, Sep 29, 2010 at 11:31 PM, Adam Barth <<a href="mailto:abarth@webkit.org">abarth@webkit.org</a>> wrote:<br>
>>> Tonight I wrote a new webkit-patch command for detecting flaky tests.<br>
>>> Here the tests that have flaked out on the Snow Leopard (Tests) build<br>
>>> bot during the last 2000 revisions. This makes a good "hit list" of<br>
>>> tests to fix to reduce flakiness. (The worst offenders are at the<br>
>>> bottom).<br>
>>><br>
>>> Take aways:<br>
>>><br>
>>> 1) compositing/geometry/limit-layer-bounds-transformed-overflow.html<br>
>>> is by far the worst offender.<br>
>>> 2) The websocket tests are ridiculously flaky.<br>
>>> 3) The appcache tests also have a serious flakiness problem.<br>
>>><br>
>>> I'll run the last 10000 revisions over night and report on the results.<br>
>>><br>
>>> Adam<br>
>>><br>
>>><br>
>>> === Results ===<br>
>>> Occurances Test name<br>
>>> 1 compositing/reflections/nested-reflection-animated.html<br>
>>> 1 fast/css/font-face-download-error.html<br>
>>> 1 fast/dom/collection-null-like-arguments.html<br>
>>> 1 fast/history/history-subframe-with-name.html<br>
>>> 1 fast/js/sputnik/Conformance/13_Function_Definition/13.2_Creating_Function_Objects/S13.2.2_A5_T1.html<br>
>>> 1 fast/js/sputnik/Conformance/13_Function_Definition/13.2_Creating_Function_Objects/S13.2.2_A5_T2.html<br>
>>> 1 fast/js/vardecl-preserve-arguments.html<br>
>>> 1 http/tests/appcache/different-https-origin-resource-main.html<br>
>>> 1 http/tests/appcache/fallback.html<br>
>>> 1 http/tests/appcache/manifest-redirect.html<br>
>>> 1 http/tests/appcache/origin-quota.html<br>
>>> 1 http/tests/appcache/resource-redirect.html<br>
>>> 1 http/tests/appcache/top-frame-3.html<br>
>>> 1 http/tests/appcache/update-cache.html<br>
>>> 1 http/tests/appcache/xhr-foreign-resource.html<br>
>>> 1 http/tests/cache/subresource-expiration.html<br>
>>> 1 http/tests/loading/basic-credentials-sent-automatically.html<br>
>>> 1 http/tests/misc/uncacheable-script-repeated.html<br>
>>> 1 http/tests/navigation/changing-frame-hierarchy-in-onload.html<br>
>>> 1 http/tests/navigation/ping-cross-origin-from-https.html<br>
>>> 1 http/tests/navigation/ping-cross-origin.html<br>
>>> 1 http/tests/navigation/post-goback-same-url.html<br>
>>> 1 http/tests/plugins/get-url.html<br>
>>> 1 http/tests/plugins/npapi-response-headers.html<br>
>>> 1 http/tests/plugins/third-party-cookie-accept-policy.html<br>
>>> 1 http/tests/security/credentials-in-referer.html<br>
>>> 1 http/tests/security/cross-frame-access-protocol-explicit-domain.html<br>
>>> 1 inspector/debugger-pause-on-breakpoint.html<br>
>>> 1 inspector/extensions-events.html<br>
>>> 1 media/audio-constructor.html<br>
>>> 1 media/video-currentTime-set.html<br>
>>> 1 plugins/destroy-stream-twice.html<br>
>>> 1 plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html<br>
>>> 1 svg/custom/use-invalid-style.svg<br>
>>> 1 transitions/transition-end-event-transform.html<br>
>>> 1 websocket/tests/send.html<br>
>>> 1 websocket/tests/simple-stress.html<br>
>>> 1 websocket/tests/sub-protocol-with-space.html<br>
>>> 1 websocket/tests/url-no-trailing-slash.html<br>
>>> 1 websocket/tests/url-with-empty-query.html<br>
>>> 1 websocket/tests/url-with-query.html<br>
>>> 1 websocket/tests/websocket-pending-activity.html<br>
>>> 1 websocket/tests/workers/close-in-onmessage-crash.html<br>
>>> 2 http/tests/appcache/foreign-iframe-main.html<br>
>>> 2 http/tests/appcache/local-content.html<br>
>>> 2 http/tests/appcache/main-resource-hash.html<br>
>>> 2 http/tests/appcache/non-html.xhtml<br>
>>> 2 http/tests/appcache/reload.html<br>
>>> 2 http/tests/css/css-image-loading.html<br>
>>> 2 http/tests/plugins/cross-frame-object-access.html<br>
>>> 2 http/tests/security/cross-frame-access-port-explicit-domain.html<br>
>>> 2 security/block-test.html<br>
>>> 2 websocket/tests/bad-sub-protocol-non-ascii.html<br>
>>> 2 websocket/tests/handshake-fail-by-sub-protocol-mismatch.html<br>
>>> 2 websocket/tests/simple.html<br>
>>> 2 websocket/tests/unicode.html<br>
>>> 3 http/tests/appcache/cyrillic-uri.html<br>
>>> 3 http/tests/appcache/deferred-events-delete-while-raising.html<br>
>>> 3 http/tests/appcache/remove-cache.html<br>
>>> 3 http/tests/appcache/top-frame-4.html<br>
>>> 3 http/tests/navigation/image-load-in-unload-handler.html<br>
>>> 3 websocket/tests/handshake-fail-by-cross-origin.html<br>
>>> 3 websocket/tests/<a href="http://httponly-cookie.pl" target="_blank">httponly-cookie.pl</a><br>
>>> 3 websocket/tests/long-invalid-header.html<br>
>>> 3 websocket/tests/sub-protocol.html<br>
>>> 3 websocket/tests/url-with-query-for-no-query.html<br>
>>> 4 fast/canvas/webgl/gl-object-get-calls.html<br>
>>> 4 http/tests/navigation/anchor-basic.html<br>
>>> 4 websocket/tests/bad-sub-protocol-control-chars.html<br>
>>> 4 websocket/tests/frame-length-longer-than-buffer.html<br>
>>> 4 websocket/tests/frame-length-skip.html<br>
>>> 4 websocket/tests/frame-lengths.html<br>
>>> 4 websocket/tests/reload-crash.html<br>
>>> 4 websocket/tests/url-with-credential.html<br>
>>> 5 websocket/tests/bad-sub-protocol-empty.html<br>
>>> 5 websocket/tests/error-detect.html<br>
>>> 5 websocket/tests/handshake-error.html<br>
>>> 6 websocket/tests/handshake-challenge-randomness.html<br>
>>> 6 websocket/tests/null-character.html<br>
>>> 7 http/tests/security/cross-origin-css.html<br>
>>> 7 websocket/tests/bufferedAmount-after-close.html<br>
>>> 7 websocket/tests/close-on-unload.html<br>
>>> 7 websocket/tests/frame-length-overflow.html<br>
>>> 7 websocket/tests/handshake-fail-by-no-cr.html<br>
>>> 8 websocket/tests/multiple-connections.html<br>
>>> 9 websocket/tests/alert-in-event-handler.html<br>
>>> 9 websocket/tests/close-on-unload-and-force-gc.html<br>
>>> 10 websocket/tests/bad-handshake-crash.html<br>
>>> 11 websocket/tests/cross-origin.html<br>
>>> 12 http/tests/navigation/ping-same-origin.html<br>
>>> 13 websocket/tests/close-on-unload-reference-in-parent.html<br>
>>> 15 websocket/tests/close-on-navigate-new-location.html<br>
>>> 19 media/audio-controls-rendering.html<br>
>>> 50 compositing/geometry/limit-layer-bounds-transformed-overflow.html<br>
>>><br>
>><br>
><br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</div></div></blockquote></div><br>