I agree with Maciej's response, but at the same time I can understand why Adam was so frustrated. He (and others) have pointed out stuff like this on and off list over and over again with little apparent change...<div>
<br></div><div>But that's not what I'm most worried about;<span class="Apple-style-span" style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; "> why this was broken in the tree for 12 hours?? It seems like, at the very least, every single person who committed in that time frame should have taken a look at the tree after committing [1]. Why did not one of those people roll the patch out when it was clear that there were failures and Alexey wasn't in the process of fixing them?</span></div>
<div><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;"><br></span></font></div><div><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;">J</span></font></div>
<div><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;"><br></span></font></div><div><font class="Apple-style-span" face="arial, sans-serif"><span class="Apple-style-span" style="border-collapse: collapse;">[1] <span class="Apple-style-span" style="font-size: 13px; ">Yeah, in theory looking before hand and not landing while it's on fire is better, but I'm talking about the _bare minimum_ of what should have happened.</span><br>
</span></font><div><br><div class="gmail_quote">On Thu, Jul 8, 2010 at 12:18 AM, Adam Barth <span dir="ltr"><<a href="mailto:abarth@webkit.org">abarth@webkit.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Sorry for singling you out Alexey. I was just frustrated last night.<br>
<div class="im"><br>
On Wed, Jul 7, 2010 at 8:58 AM, Alexey Proskuryakov <<a href="mailto:ap@webkit.org">ap@webkit.org</a>> wrote:<br>
> 07.07.2010, в 00:47, Adam Barth написал(а):<br>
>> If you're tired of my complaining about the tree being red, you can<br>
>> skip this message.<br>
><br>
> I understand that you're frustrated, but I think that you're misinterpreting what happened.<br>
><br>
>> 1) He could have run-webkit-tests before committing his change.<br>
><br>
> I did that. I made the mistake of running a wrong subset though (forgot that local xmlhttprequest tests were no longer in fast/dom).<br>
<br>
</div>Maybe the root cause here is that the test suite takes too long to<br>
run? We can make run-webkit-tests faster...<br>
<div class="im"><br>
>> 2) If he didn't have time to run the tests locally, he could have used<br>
>> the commit-queue to run-webkit-tests before it landed his patch.<br>
><br>
> Using commit-queue while it still doesn't provide correct svn blame is trading short term problems for longer term ones. Yes, one can still open a changeset by number, but having names really helps read svn blame.<br>
<br>
</div>This problem is now fixed thanks to William Siegrist. Patches written<br>
by committers show up correctly in SVN blame and trac even if they're<br>
landed by the commit-queue.<br>
<div class="im"><br>
>> 3) He could have looked at the tree when sheriff-bot informed him that<br>
>> he might have broken Leopard Intel Debug by pinging him in #webkit and<br>
>> commenting on his bug:<br>
>> <<a href="https://bugs.webkit.org/show_bug.cgi?id=41156#c8" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=41156#c8</a>>.<br>
><br>
> I worked with Qt guys on fixing tests on Qt, and I watched the tree, which didn't show any sign of a problem from my patch at the time. Perhaps I'm starting to rely on sheriff bot too much - it didn't complain about any platforms besides Leopard Intel Debug.<br>
<br>
</div>It only complains once to avoid spamming when it makes a mistake.<br>
<div class="im"><br>
> Leopard builder was seriously broken yesterday, so I didn't pay attention when it complained about a problem many hours later. In retrospect, that was a mistake.<br>
<br>
</div>I think we can improve this by having sheriff-bot say which tests<br>
broke. I bet if you saw these tests listed, you'd have realized what<br>
was going one.<br>
<div class="im"><br>
>> these failures remained in the tree until I cleaned them up<br>
><br>
> I see that Tiger bot still has a unique failure, and will investigate it as soon as possible.<br>
<br>
</div>Thanks.<br>
<font color="#888888"><br>
Adam<br>
</font><div><div></div><div class="h5">_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</div></div></blockquote></div><br></div></div>