<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><br></div><div>We do sometimes land changes that are reviewed on IRC and that don't correspond to bugs. The main criteria for when this is appropriate are:</div><div>- the change is simple, and doesn't need many eyes looking at it;</div><div>- there is no historical trail to maintain, no one is going to look at svn blame and wonder why this change was made 10 years ago.</div><div><br></div><div>A change that modifies cross platform code to fix a platform specific (?) crash, and that doesn't even include a test case definitely needs to be tracked in WebKit Bugzilla.</div><br><div><span class="Apple-style-span" style="font-size: 12px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>- WBR, Alexey Proskuryakov</div></div><br class="Apple-interchange-newline"></span><div>06.07.2010, в 5:52, <a href="mailto:kov@webkit.org">kov@webkit.org</a> написал(а):</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div><div id="msg"><dl class="meta" style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; border-top-width: 1px; border-right-width: 1px; border-bottom-width: 1px; border-left-width: 1px; border-top-color: rgb(0, 0, 102); border-right-color: rgb(0, 0, 102); border-bottom-color: rgb(0, 0, 102); border-left-color: rgb(0, 0, 102); border-top-style: solid; border-right-style: solid; border-bottom-style: solid; border-left-style: solid; background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(51, 102, 153); padding-top: 6px; padding-right: 6px; padding-bottom: 6px; padding-left: 6px; color: rgb(255, 255, 255); background-position: initial initial; "><dt style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; float: left; width: 6em; font-weight: bold; ">Revision</dt><dd><a href="http://trac.webkit.org/projects/webkit/changeset/62546" style="font-weight: bold; color: rgb(255, 204, 51); ">62546</a></dd><dt style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; float: left; width: 6em; font-weight: bold; ">Author</dt><dd><a href="mailto:kov@webkit.org" style="font-weight: bold; color: rgb(255, 204, 51); ">kov@webkit.org</a></dd><dt style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; float: left; width: 6em; font-weight: bold; ">Date</dt><dd>2010-07-06 05:52:30 -0700 (Tue, 06 Jul 2010)</dd></dl><h3 style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; font-weight: bold; ">Log Message</h3><pre style="overflow-x: auto; overflow-y: auto; background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(255, 255, 204); border-top-width: 1px; border-right-width: 1px; border-bottom-width: 1px; border-left-width: 1px; border-top-color: rgb(255, 170, 0); border-right-color: rgb(255, 170, 0); border-bottom-color: rgb(255, 170, 0); border-left-color: rgb(255, 170, 0); border-top-style: solid; border-right-style: solid; border-bottom-style: solid; border-left-style: solid; padding-top: 6px; padding-right: 6px; padding-bottom: 6px; padding-left: 6px; background-position: initial initial; ">2010-07-06 Gustavo Noronha Silva <<a href="mailto:gustavo.noronha@collabora.co.uk">gustavo.noronha@collabora.co.uk</a>>
Rubber-stamped by Xan Lopez.
Crash when hitting back on some pages
<a href="http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575236">http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575236</a>
Also NULL-check document, in hopes of fixing this hard to
reproduce crash that we are getting reported quite a bit.
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):</pre><h3 style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; font-weight: bold; ">Modified Paths</h3><ul style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; "><li style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; "><a href="#trunkWebCoreChangeLog">trunk/WebCore/ChangeLog</a></li><li style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; "><a href="#trunkWebCorepageFrameViewcpp">trunk/WebCore/page/FrameView.cpp</a></li></ul></div><div id="patch" style="width: 898px; "><h3 style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; font-weight: bold; ">Diff</h3><a id="trunkWebCoreChangeLog"></a><div class="modfile" style="border-top-width: 1px; border-right-width: 1px; border-bottom-width: 1px; border-left-width: 1px; border-top-style: solid; border-right-style: solid; border-bottom-style: solid; border-left-style: solid; border-top-color: rgb(204, 204, 204); border-right-color: rgb(204, 204, 204); border-bottom-color: rgb(204, 204, 204); border-left-color: rgb(204, 204, 204); margin-top: 10px; margin-right: 0px; margin-bottom: 10px; margin-left: 0px; "><h4 style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; padding-top: 8px; padding-right: 8px; padding-bottom: 8px; padding-left: 8px; background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(51, 102, 153); color: rgb(255, 255, 255); margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; background-position: initial initial; ">Modified: trunk/WebCore/ChangeLog (62545 => 62546)</h4><pre class="diff" style="padding-top: 0px; padding-right: 0px; padding-bottom: 10px; padding-left: 0px; line-height: 1.2em; margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; width: 896px; background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(238, 238, 238); overflow-x: auto; overflow-y: auto; background-position: initial initial; "><span style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; ">
<span class="info" style="color: rgb(136, 136, 136); background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(255, 255, 255); display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; position: static; z-index: auto; ">--- trunk/WebCore/ChangeLog 2010-07-06 12:11:06 UTC (rev 62545)
+++ trunk/WebCore/ChangeLog 2010-07-06 12:52:30 UTC (rev 62546)
</span><span class="lines" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; color: rgb(136, 136, 136); background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(255, 255, 255); background-position: initial initial; ">@@ -1,3 +1,16 @@
</span><ins style="background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(221, 255, 221); text-decoration: none; display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; background-position: initial initial; ">+2010-07-06 Gustavo Noronha Silva <<a href="mailto:gustavo.noronha@collabora.co.uk">gustavo.noronha@collabora.co.uk</a>>
+
+ Rubber-stamped by Xan Lopez.
+
+ Crash when hitting back on some pages
+ <a href="http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575236">http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=575236</a>
+
+ Also NULL-check document, in hopes of fixing this hard to
+ reproduce crash that we are getting reported quite a bit.
+
+ * page/FrameView.cpp:
+ (WebCore::FrameView::windowClipRect):
+
</ins><span class="cx" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; "> 2010-07-05 Ilya Tikhonovsky <<a href="mailto:loislo@chromium.org">loislo@chromium.org</a>>
</span><span class="cx" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; ">
</span><span class="cx" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; "> Reviewed by Yury Semikhatsky.
</span></span></pre></div><a id="trunkWebCorepageFrameViewcpp"></a><div class="modfile" style="border-top-width: 1px; border-right-width: 1px; border-bottom-width: 1px; border-left-width: 1px; border-top-style: solid; border-right-style: solid; border-bottom-style: solid; border-left-style: solid; border-top-color: rgb(204, 204, 204); border-right-color: rgb(204, 204, 204); border-bottom-color: rgb(204, 204, 204); border-left-color: rgb(204, 204, 204); margin-top: 10px; margin-right: 0px; margin-bottom: 10px; margin-left: 0px; "><h4 style="font-family: verdana, arial, helvetica, sans-serif; font-size: 10pt; padding-top: 8px; padding-right: 8px; padding-bottom: 8px; padding-left: 8px; background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(51, 102, 153); color: rgb(255, 255, 255); margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; background-position: initial initial; ">Modified: trunk/WebCore/page/FrameView.cpp (62545 => 62546)</h4><pre class="diff" style="padding-top: 0px; padding-right: 0px; padding-bottom: 10px; padding-left: 0px; line-height: 1.2em; margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; width: 896px; background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(238, 238, 238); overflow-x: auto; overflow-y: auto; background-position: initial initial; "><span style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; ">
<span class="info" style="color: rgb(136, 136, 136); background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(255, 255, 255); display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; background-position: initial initial; ">--- trunk/WebCore/page/FrameView.cpp 2010-07-06 12:11:06 UTC (rev 62545)
+++ trunk/WebCore/page/FrameView.cpp 2010-07-06 12:52:30 UTC (rev 62546)
</span><span class="lines" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; color: rgb(136, 136, 136); background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(255, 255, 255); background-position: initial initial; ">@@ -1670,7 +1670,7 @@
</span><span class="cx" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; ">
</span><span class="cx" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; "> // Set our clip rect to be our contents.
</span><span class="cx" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; "> IntRect clipRect = contentsToWindow(visibleContentRect(!clipToContents));
</span><del style="background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(255, 221, 221); text-decoration: none; display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; background-position: initial initial; ">- if (!m_frame || !m_frame->document()->ownerElement())
</del><ins style="background-image: initial; background-repeat: initial; background-attachment: initial; -webkit-background-clip: initial; -webkit-background-origin: initial; background-color: rgb(221, 255, 221); text-decoration: none; display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; background-position: initial initial; ">+ if (!m_frame || !m_frame->document() || !m_frame->document()->ownerElement())
</ins><span class="cx" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; "> return clipRect;
</span><span class="cx" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; ">
</span><span class="cx" style="display: block; padding-top: 0px; padding-right: 10px; padding-bottom: 0px; padding-left: 10px; "> // Take our owner element and get the clip rect from the enclosing layer.
</span></span></pre></div></div>_______________________________________________<br>webkit-changes mailing list<br><a href="mailto:webkit-changes@lists.webkit.org">webkit-changes@lists.webkit.org</a><br><a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes">http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes</a><br></div></span></blockquote></div><br><div apple-content-edited="true"> <span class="Apple-style-span" style="border-collapse: separate; border-spacing: 0px 0px; color: rgb(0, 0, 0); font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: auto; -khtml-text-decorations-in-effect: none; text-indent: 0px; -apple-text-size-adjust: auto; text-transform: none; orphans: 2; white-space: normal; widows: 2; word-spacing: 0px; "><div style="word-wrap: break-word; -khtml-nbsp-mode: space; -khtml-line-break: after-white-space; "><div><span class="Apple-style-span" style="font-size: medium;"><br></span></div></div></span></div></body></html>