<meta http-equiv="content-type" content="text/html; charset=utf-8">Here's the prototype I made during the hackathon that simply uses a bunch of Javascript to make it easier to type up comments:<div><a href="http://ascherkus.appspot.com/bugzilla/index.html">http://ascherkus.appspot.com/bugzilla/index.html</a></div>
<div><br></div><div>I'm not a WebKit reviewer, but from what I gathered during the session there's a lot of copying and pasting involved. I focused on trying to fix that particular issue.</div><div><br></div><div>
Double click a line to add a comment. Code context + comment gets appended into the patch comment box. It's purely visual -- nothing gets persisted.</div><div><br></div><div>Andrew</div><div><br><div class="gmail_quote">
On Mon, Apr 19, 2010 at 4:20 PM, Ojan Vafai <span dir="ltr"><<a href="mailto:ojan@chromium.org">ojan@chromium.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I don't know if it's up anywhere. The other group's approach adds more directly upon the current review system. I don't think we need to choose one vs. another (at least not in the short term). Not that you were suggesting that.<div>
<br></div><div><font color="#888888">Ojan</font><div><div></div><div class="h5"><br><br><div class="gmail_quote">On Mon, Apr 19, 2010 at 4:06 PM, Adam Barth <span dir="ltr"><<a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+scherkus<br>
<div><div></div><div><br>
On Mon, Apr 19, 2010 at 4:01 PM, Maciej Stachowiak <<a href="mailto:mjs@apple.com" target="_blank">mjs@apple.com</a>> wrote:<br>
><br>
> I heard another group coded up a different approach to improving reviews -<br>
> does anyone have a URL for that, so we can compare?<br>
> Cheers,<br>
> Maciej<br>
><br>
> On Apr 19, 2010, at 3:35 PM, Ojan Vafai wrote:<br>
><br>
> At the hackathon last Tuesday, a few of us put together mashup style<br>
> rietveld integration with <a href="http://bugs.webkit.org" target="_blank">bugs.webkit.org</a>. It currently requires a chrome<br>
> extension. We'll integrate properly with bugzilla based on feedback if this<br>
> seems to be a value add for the project.<br>
> <a href="http://webkit-rietveld.googlecode.com/svn/trunk/chrome-extension/webkit-cr.crx" target="_blank">http://webkit-rietveld.googlecode.com/svn/trunk/chrome-extension/webkit-cr.crx</a><br>
> You can try it out on the *last* attachment<br>
> on <a href="https://bugs.webkit.org/show_bug.cgi?id=37531" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=37531</a>.<br>
> You'll see another link next to each attachment labelled "Fancy Review".<br>
> This loads a page much like the current review page, but<br>
> with <a href="http://wkrietveld.appspot.com" target="_blank">wkrietveld.appspot.com</a> in the top frame (wkrietveld is our fork of<br>
> rietveld). You can then make comments in rietveld. When you click the submit<br>
> button, the comments are published *both* in Reitveld and<br>
> to <a href="http://bugs.webkit.org" target="_blank">bugs.webkit.org</a>.<br>
> We do not intend to remove the old code review system for people who prefer<br>
> to stick to that.<br>
><br>
> Known issues:<br>
> -Currently, only works with patches that are uploaded using "webkit-patch<br>
> upload --fancy-review".<br>
> -Due to using a chrome extension rather than a tighter integration, some<br>
> things are a bit janky (e.g. the initial load).<br>
> -Each time a patch is uploaded, it currently creates a new rietveld issue.<br>
> Ojan _______________________________________________<br>
> webkit-dev mailing list<br>
> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
><br>
><br>
> _______________________________________________<br>
> webkit-dev mailing list<br>
> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
><br>
><br>
</div></div></blockquote></div><br></div></div></div>
</blockquote></div><br></div>