<br><br><div class="gmail_quote">On Tue, Apr 13, 2010 at 11:39 PM, David Levin <span dir="ltr"><<a href="mailto:levin@google.com">levin@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br><br><div class="gmail_quote"><div class="im">On Tue, Apr 13, 2010 at 11:35 PM, Adam Barth <span dir="ltr"><<a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Ah, sorry, I meant to the point where the library was integrated with<br>
the various build systems, etc. Maybe that's already possible today.<br>
I haven't investigated it in detail. It probably also makes sense to<br>
talk about correctness between steps (1) and (2), once we have the<br>
tests and their results to compare across browsers.<br>
<font color="#888888"><br>
Adam<br>
</font><div><div></div><div><br>
<br>
On Tue, Apr 13, 2010 at 11:28 PM, Darin Fisher <<a href="mailto:darin@chromium.org" target="_blank">darin@chromium.org</a>> wrote:<br>
> #4 is already basically done. See USE(GOOGLEURL).<br>
> -Darin<br>
><br>
><br>
> On Tue, Apr 13, 2010 at 11:17 PM, Adam Barth <<a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a>> wrote:<br>
>><br>
>> I think Maciej took notes, but my recollection is as follows:<br>
>><br>
>> 1) Convert as many of the unit tests to LayoutTests as possible.<br>
>> 2) Land GURL in <a href="http://svn.webkit.org" target="_blank">svn.webkit.org</a> as is.<br></div></div></blockquote><div><br></div></div><div>I think there was: </div><div> 2.5 Change the name from GoogleURL to something else.</div>
<div> </div><div>(WebKitUrl?)</div><div><div></div><div class="h5"><div><br></div></div></div></div></blockquote><div><br></div><div>WebKitUrl suggests that it lives more at the higher levels of the code base (with the other WebKit* stuff). How about URLCore living at the same level as WebCore and JavaScriptCore?</div>
<div><br></div><div>-Darin</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div class="gmail_quote"><div><div class="h5"><div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>
>> 3) Convert GURL to WebKit style. </div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>
>> 4) Make an ifdef that lets ports switch between KURL and GURL.<br>
>><br>
>> Once we get to this point, it will be easy to evaluate the performance<br>
>> and correctness impact of switching from KURL to GURL. Ideally, we'd<br>
>> have a "bake-off" and pick the best parser based on some objective<br>
>> criterion. If KURL wins the bake-off, we should consider refactoring<br>
>> KURL's parser not to depend on WebCore::String (or really any of<br>
>> WebCore). If GURL wins the bake-off, we should document (either with<br>
>> comments or tests) which parts of GURL's API is needed by Chromium but<br>
>> not necessarily need by other ports.<br>
>><br>
>> Adam<br>
>><br>
>><br>
>> On Tue, Apr 13, 2010 at 9:17 PM, Chris Jerdonek <<a href="mailto:cjerdonek@webkit.org" target="_blank">cjerdonek@webkit.org</a>><br>
>> wrote:<br>
>> > Regarding the URL parsing code, could someone that attended the<br>
>> > session list what steps were proposed or tentatively agreed to (of<br>
>> > which the below is the first)?<br>
>> ><br>
>> > Thanks a lot,<br>
>> > --Chris<br>
>> ><br>
>> ><br>
>> ><br>
>> > On Tue, Apr 13, 2010 at 1:46 AM, Adam Barth <<a href="mailto:abarth@webkit.org" target="_blank">abarth@webkit.org</a>> wrote:<br>
>> >> Have you ever wanted WebKit's URL parsing to be awesome? Do crazy<br>
>> >> characters in URLs keep you up at night? Do you love writing tests?<br>
>> >><br>
>> >> If you answered yes to any of these questions, you might want to join<br>
>> >> the URL hackathon. In this hackathon, we're adding a ton of test of<br>
>> >> our URL parsing code by adapting a BSD-licensed unit test suit into a<br>
>> >> set of LayoutTests.<br>
>> >><br>
>> >> You can find the instructions and sign-up sheet at following URL:<br>
>> >><br>
>> >><br>
>> >> <a href="http://docs.google.com/Doc?docid=0AZpchfQ5mBrEZGQ0cDh3YzRfMTVnZmZ3dGNmNg&hl=en" target="_blank">http://docs.google.com/Doc?docid=0AZpchfQ5mBrEZGQ0cDh3YzRfMTVnZmZ3dGNmNg&hl=en</a><br>
>> >><br>
>> >> Thanks, and happy hacking!<br>
>> >> Adam<br>
>> >> _______________________________________________<br>
>> >> webkit-dev mailing list<br>
>> >> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
>> >> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
>> >><br>
>> ><br>
>> _______________________________________________<br>
>> webkit-dev mailing list<br>
>> <a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
>> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
><br>
><br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org" target="_blank">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</div></div></blockquote></div></div></div><br>
</blockquote></div><br>