<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; " class=""><div><div class="">On Nov 12, 2009, at 6:59 PM, Ojan Vafai wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class=""><div class="gmail_quote">On Thu, Nov 12, 2009 at 3:48 PM, Adam Roben <span dir="ltr" class=""><<a href="mailto:aroben@apple.com" class="">aroben@apple.com</a>></span> wrote:<br class=""><blockquote style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; " class="gmail_quote">
<div style="word-wrap:break-word" class=""><div class="im"><div class=""><div class="">On Nov 12, 2009, at 6:38 PM, Ojan Vafai wrote:</div><blockquote type="cite"><span style="border-collapse:separate;font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;font-size:medium" class=""><span style="border-collapse:collapse;font-family:arial, sans-serif;font-size:13px" class=""><div class="">
2. Can grab layout test results from the try servers. This would reduce the need/occurence of committing Mac expectations and then cleaning up other platforms post commit.</div></span></span></blockquote></div></div><div class="">
Without being able to see the loaded page on that platform, how do you know if the results are correct?</div><div class=""><br class=""></div><div class="">(If you're able to verify the results just based on the test output, maybe the test should be cross-platform!)</div>
</div></blockquote><div class=""><br class=""></div><div class="">This entirely depends on the change you're making. For example, with a change that makes buttons 1px wider it's easy to verify from the layout test diff that the new results are correct.</div></div></div></blockquote><div><br></div>That's true.</div><div><br><blockquote type="cite"><div class=""><div class="gmail_quote"><div class=""> It's also easy to spot tests with "FAIL" or "PASS" in the output. :)</div></div></div></blockquote><div><br></div>I'd hope that those tests would have cross-platform results, since clearly the condition is testable without having access to a full render tree dump.</div><div><br></div><div>-Adam</div><div><br></div></body></html>