<br><br><div class="gmail_quote">On Mon, Sep 21, 2009 at 1:22 PM, Maciej Stachowiak <span dir="ltr"><<a href="mailto:mjs@apple.com">mjs@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word"><br><div>Slightly better. The only real difference it would make is if someone tests using a === comparison to undefined (as opposed to == or just a plain boolean test).</div><div><br></div>
</div></blockquote><div><br></div><div>One reason why I'm pursuing this is that a naive google developer would probably use our in-house javascript library to check for localStorage support like so:</div><div><br></div>
<div>if (goog.isDef(window.localStorage)) {</div><div> // do stuff</div><div>}</div><div><br></div><div>Where goog.isDef() is defined like so:</div><div><br></div><div><div>goog.isDef = function(val) {</div><div> return val !== undefined;</div>
<div>};</div><div><br></div><div>So I doubt that anyone would explicitly ever write "if (window.localStorage === undefined)" or "if (typeof window.localStorage == "undefined")", but plenty of people use standard library calls without being aware of all the implications.</div>
<div><br></div><div>I agree with your conclusion, Jeremy - we should definitely make certain that chromium never ships experimental features outside of the dev channel.</div></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word"><div></div><div>Regards,</div><div>Maciej</div><font color="#888888"><div><br></div></font></div><br>_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
<br></blockquote></div><br>