<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 21, 2009, at 6:56 PM, Sam Weinig wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">I believe it is quite well established that a space should not be allowed before a ; or , in such circumstances. (I have r-ed for it even ;) ). I think we should definitely explicitly call this out in the guidelines if it is not already.</blockquote><div><br></div><div>The examples in the coding style guidelines use the right style (i.e. no space before the comma or semicolon), it would be fine to make it an explicit rule.</div><div><br></div><div> - Maciej</div><br><blockquote type="cite"><div> <br></div><div>-Sam<br><br><div class="gmail_quote">On Tue, Jul 21, 2009 at 4:05 PM, Kenneth Christiansen <span dir="ltr"><<a href="mailto:kenneth.christiansen@openbossa.org">kenneth.christiansen@openbossa.org</a>></span> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">Hi there,<br> <br> In bug 27499 (<a href="https://bugs.webkit.org/show_bug.cgi?id=27499" target="_blank">https://bugs.webkit.org/show_bug.cgi?id=27499</a>) it was<br> pointed out that the coding style guide doesn't clarify whether it is<br> allowed to place a space before a comma or semicolon in a control<br> condition or in functions.<br> <br> Thus asking the question whether the three following code snippets are<br> should be discouraged by the coding style guide or not:<br> <br> for (int i = 0 ; i < 10 ; i++)<br> doSomething();<br> <br> <br> // Qt's foreach<br> foreach (QString &item , items)<br> doSomething();<br> <br> f(a , b);<br> <br> Personally I would opt for discouraging this, which David Levin points<br> out to be more or less the current project style.<br> <br> If we can agree on this, I can patch the coding style guide.<br> <br> Cheers,<br> Kenneth<br> _______________________________________________<br> webkit-dev mailing list<br> <a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br> </blockquote></div><br></div> _______________________________________________<br>webkit-dev mailing list<br><a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev<br></blockquote></div><br></body></html>