<br><br><div class="gmail_quote">On Wed, May 27, 2009 at 11:47 AM, Adam Barth <span dir="ltr"><<a href="mailto:abarth@webkit.org">abarth@webkit.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I've been doing some work recently in our JavaScript bindings. As<br>
part of this work, I've noticed that WebCore/bindings/js and<br>
WebCore/bindings/v8 have drifted apart in some details. It's kind of<br>
ridiculous that we have so much duplicated code in these two folders.<br>
We should try to re-organize our bindings to share as much code as<br>
possible.<br>
<br>
1) Where should the common code live? One option is to have:<br>
<br>
WebCore/bindings/js <--- common code<br>
WebCore/bindings/jsc <--- JSC specific<br>
WebCore/bindings/v8 <--- V8 specific<br>
<br>
2) How much should we try to share? For example, we could have an<br>
abstracted notion of ArgList that works for both engines, or we could<br>
be happy to factor out common routines like createWindow<br>
<<a href="http://trac.webkit.org/browser/trunk/WebCore/bindings/js/JSDOMWindowCustom.cpp#L285" target="_blank">http://trac.webkit.org/browser/trunk/WebCore/bindings/js/JSDOMWindowCustom.cpp#L285</a>>.<br>
<br>
I presume Sam is a good contact for the JSC bindings. Who's a good<br>
contact for the V8 bindings?</blockquote><div><br></div><div>dglazkov</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><br>
<br>
Thanks,<br>
Adam<br>
_______________________________________________<br>
webkit-dev mailing list<br>
<a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
<a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
</blockquote></div><br>