<html><head><style type="text/css"><!-- DIV {margin:0px;} --></style></head><body><div style="font-family:verdana, helvetica, sans-serif;font-size:10pt"><div>Hi Simone,</div><div><br></div><div>Code contribution guidelines are here:</div><div><br></div><div>http://webkit.org/coding/contributing.html</div><div><br></div><div>Please open a new bug on <https://bugs.webkit.org/> and post your patch there with its review flag set. (Feel free to CC me on the bug.) Note that your patch should also have ChangeLog entries, as explained on the webkit.org web site.</div><div><br></div><div>Looking at the two patches, I think they're fine as-is and would have no problem landing in the source tree.</div><div><br></div><div>Thanks for your contribution!</div><div><br></div><div>Dave</div><div><br></div><div style="font-family:verdana, helvetica, sans-serif;font-size:10pt"><br><div style="font-family:Courier New, monaco, monospace,
sans-serif;font-size:10pt"><font size="2" face="Tahoma"><hr size="1"><b><span style="font-weight: bold;">From:</span></b> Simone Fiorentino <simone.fiorentino@consulenti.fastweb.it><br><b><span style="font-weight: bold;">To:</span></b> webkit-dev@lists.webkit.org<br><b><span style="font-weight: bold;">Sent:</span></b> Thursday, March 5, 2009 5:33:27 AM<br><b><span style="font-weight: bold;">Subject:</span></b> [webkit-dev] request to add SH4 platform<br></font><br>
Hi,<br>I would like to gratify you for your great work.<br>I'm working in porting WebKit for SH4 platform.<br>I had some problems related to non-aligned memory accesses as done in <br>WebCore::equal(StringImpl* string, const UChar* characters, unsigned length) <br>function for the SH4 platform.<br>My question is: can you add support in WebKit sources for SH4 platform?<br><br>In attachment you can find two little patches (against WebKit trunk) that <br>introduce the SH4 platform and solves the non-aligned memory accesses (I use <br>the same code as per ARM platform).<br><br>Best regards.<br><br>Tnx,<br>Simone.<br></div></div><div style="position:fixed"></div></div></body></html>