Yup, that was my plan. Custom will be respected by both code generators.<div><br></div><div>-Darin</div><div><br><br><div class="gmail_quote">On Tue, Feb 3, 2009 at 4:06 PM, Dimitri Glazkov <span dir="ltr"><<a href="mailto:dglazkov@google.com">dglazkov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">To minimize the span of the changes, let's keep Custom as well, which<br>
in this context should mean -- Custom for all platforms. WDYT?<br>
<br>
:DG<<br>
<div><div></div><div class="h5"><br>
On Mon, Feb 2, 2009 at 5:16 PM, Geoffrey Garen <<a href="mailto:ggaren@apple.com">ggaren@apple.com</a>> wrote:<br>
>> I was about to upstream some patches that add #ifdefs to the WebCore IDL<br>
>> files. In many cases, the only delta is the removal of the Custom<br>
>> attribute. Eric Seidel pointed out that it might be better to rename those<br>
>> usages of Custom to JSCCustom to avoid #ifdefs.<br>
>><br>
>> This change would avoid #ifdefs in Node.idl, SVGPointList.idl,<br>
>> SVGPathSegList.idl, and SVGTransformList.idl. I would similarly like to add<br>
>> a V8Custom attribute for use in the cases where the V8 bindings need custom<br>
>> code for an attribute or method. That would allow us to avoid #ifdefs in<br>
>> Document.idl.<br>
>><br>
>> Does this sound like a good idea?<br>
><br>
> I think so.<br>
><br>
> Geoff<br>
</div></div>> _______________________________________________<br>
> webkit-dev mailing list<br>
> <a href="mailto:webkit-dev@lists.webkit.org">webkit-dev@lists.webkit.org</a><br>
> <a href="http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev" target="_blank">http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev</a><br>
><br>
</blockquote></div><br></div>