[webkit-dev] Approving / Rejects PRs on GitHub when not a reviewer?

Tim Nguyen ntim at apple.com
Tue Nov 28 12:37:45 PST 2023


(I already answered this, but that message failed to reach the mailing list, sorry to the folks receiving my reply twice)

Everyone in the WebKit Github organization gets a green checkmark afaik (that’s just how the Github UI works), so as of right now that means everyone in contributors.json with a Github username.

> On Nov 28, 2023, at 12:34 PM, Darin Adler via webkit-dev <webkit-dev at lists.webkit.org> wrote:
> 
>> On Nov 28, 2023, at 3:02 PM, Chris Dumez wrote:
>> 
>> FYI, my understanding is that the person gets a *green* checkmark when the person is present in contributors.json (common case), even if not marked as a reviewer in that file.
> 
> Does anyone know why we chose green for all contributors rather than green for reviewers?
> 
> — Darin
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev



More information about the webkit-dev mailing list