[webkit-dev] Let's use -Werror on EWS?

Michael Catanzaro mcatanzaro at gnome.org
Tue May 25 04:29:23 PDT 2021

On Mon, May 24 2021 at 07:36:03 PM -0700, Darin Adler via webkit-dev 
<webkit-dev at lists.webkit.org> wrote:
> I do not know why we do not already use -Werror on GTK and WPE and I 
> support using it there after fixing all the warnings.

I'd be willing to enable it at the CMake level if it was conditional on 
-DENABLE_DEVELOPER_MODE=ON. I tried proposing that previously in 
https://bugs.webkit.org/show_bug.cgi?id=155047 but it was not approved 
at the time.

Of course we can't enable -Werror by default, though, since it would be 
offensive to distributors and non-WebKit developers trying to build 
WebKit. And it would make bisecting pretty hard for ourselves too. We 
don't want non-EWS builds to fail just because you're using a newer 
compiler or a different optimization level that causes warnings to be 
more sensitive. So it should only be used on EWS or in DEVELOPER_MODE.

More information about the webkit-dev mailing list