[webkit-dev] New EWS Non-Unified builder

[Adrian Perez de Castro]

On Thu, 29 Apr 2021 19:04:55 +0000 Ross Kirsling via webkit-dev <webkit-dev at lists.webkit.org> wrote:

> Yeah, I think it's important to clarify that nobody is "using
> non-Unified-Source building for their development", at least to my
> knowledge. Being broken by the shifting sands of unified sources is an
> everybody problem (or at the very least an "everybody that builds via CMake
> problem", which is ultimately an everybody problem).

This is pretty accurate. I do have a build directory configured manually
as non-unified so I can get its “compile_commands.json” to point tooling
at (mainly clangd, for code completion and linting), but actual builds I
do them with the “build-webkit” script.

Another situation in which I explicitly opt-in to non-unified builds is
around the time we make a release branch for the GTK and WPE ports; get
to solve the non-unified build issues and then land the patches in the
release branch as well. The goal here is to make sure that what we release
can be built non-unified, which means header includes and whatnot are
correct (at least for these ports) and we can have the confidence that
people doing cross-builds (where the set of files in each unified build
compilation unit can shift) will not have problems with the builds.

Before I did the above we used to have complaints and distributions
sometimes carrying odd patches playing whack-a-mole to get builds done
instead of properly fixing things.

Cheers,
—Adrián

 
> ________________________________
> From: Alex Christensen via webkit-dev <webkit-dev at lists.webkit.org>
> Sent: Thursday, April 29, 2021 11:03 AM
> To: Darin Adler <darin at apple.com>
> Cc: webkit-dev at lists.webkit.org <webkit-dev at lists.webkit.org>
> Subject: Re: [webkit-dev] New EWS Non-Unified builder
> 
> I don’t see the goal as “keep non-Unified-Source building” but rather “prevent unrelated build fixes when we add another file later”.  Right now when we add a new file we often have to sprinkle includes, declarations, and other build fixes in files unrelated to the current change.  If we had a bot building without unification we would be informed at the time we write the problematic code.
> 
> > On Apr 29, 2021, at 9:55 AM, Darin Adler via webkit-dev <webkit-dev at lists.webkit.org> wrote:
> >
> > Given the issue is that there are people that are using non-Unified-Source building for their development, the best fix is to add post-commit and EWS builders for one of those platforms. I do not support the idea of adding an additional builder just to “keep non-Unified-Source building” if no actively-supported platform is not choosing that build style.
> >
> > Specifically, if Sony people are most affected by this, I suggest we find a way to add Sony PlayStation post-commit and EWS builders.
> >
> > I am not convinced that we should add some kind of abstract “correct compilation” that is a separate builder.
> >
> > — Darin
> > _______________________________________________
> > webkit-dev mailing list
> > webkit-dev at lists.webkit.org
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
> 
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20210429/bcb95b0a/attachment.bin>