[webkit-dev] PSA: Bit fields won't be packed on Windows if you mix types

[Ryosuke Niwa]

On Thu, Sep 3, 2020 at 10:11 PM Fujii Hironori <fujii.hironori at gmail.com>
wrote:

>
> On Fri, Sep 4, 2020 at 1:31 PM Ryosuke Niwa <rniwa at webkit.org> wrote:
>
>> Consecutive bit fields must use the same type.
>>
>
> RenderLayer is mixing bool and unsigned in the consecutive bit fields.
> They should use only uint8_t, right?
>
> https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/rendering/RenderLayer.h#L1263
>

Under the proposed coding style guide, yes, although I highly doubt the
size of RenderLayer really matters.

- R. Niwa
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20200903/92b385a7/attachment.htm>