[webkit-dev] Reducing / removing use of Makefile based DerivedSources.make
weinig at apple.com
Tue Oct 20 16:08:49 PDT 2020
> On Oct 20, 2020, at 3:36 PM, Darin Adler <darin at apple.com> wrote:
>> On Oct 20, 2020, at 3:09 PM, Sam Weinig <weinig at apple.com> wrote:
>> For the Platform.h issue, I think we could probably engineer things in the short term to have a script phase that produces a Defines.txt that the other script phases and build rules depend on.
> We definitely can, and it’s simpler than how we do it now. I have a patch that does this for the makefile partly done and set aside. My approach was to revise each script, one at a time, to take a file with the defines rather than requiring they be passed on the command line. It doesn’t work for the parts of the makefile itself that depend directly on checking the defines (grep for findstring.*FEATURE_AND_PLATFORM_DEFINES to see those).
I think we can probably easily replace the makefile checking FEATURE_AND_PLATFORM_DEFINES itself ones.
For the ones conditionalizing adding to ADDITIONAL_BINDING_IDLS, those IDLs should just have the appropriate Conditional=* extended attribute added, then they can be included unconditionally in the makefile.
For the ones conditionalizing adding go USER_AGENT_STYLE_SHEETS, again, there doesn’t seem a real reason to keep that. The sheets are all preprocessed anyway, so we can just move those #ifdefs into the files.
I filed https://bugs.webkit.org/show_bug.cgi?id=218001 <https://bugs.webkit.org/show_bug.cgi?id=218001> for this and will get that done regardless.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the webkit-dev