[webkit-dev] Removing ACCELERATED_2D_CANVAS

[Adrian Perez de Castro]

Hello,

On Tue, 13 Oct 2020 14:36:11 +0200 zan at falconsigh.net wrote:

> ACCELERATED_2D_CANVAS feature right now is only implemented for ports using
> Cairo. Of those ports, I can only guarantee for the GTK and WPE ports that
> it works to some degree. The implementation relies on a GL-oriented Cairo
> backend that's always been deemed experimental and is not receiving a lot of
> attention anymore. As such, I propose removing the ImageBuffer backend
> implementation, along with the code guarded by the ACCELERATED_2D_CANVAS
> build guard and the relevant configuration options.
> 
> The patch removing the guarded code and build/configuration options is here,
> pending to land: https://bugs.webkit.org/show_bug.cgi?id=217603
> 
> There's also some preference cruft still left in the WebKit layer that's
> going to be removed later.

I am in favor of this removal.

We just fixed the build with the feature enabled with the idea of merging the
fix in the 2.30.x branch because it is expected to work there; but given that
whether the option improves performance or not is hit-and-miss (sometimes it
makes things go slower) and that our longer term plan is to get rid of Cairo,
I think it's good to go ahead with this and remove from trunk this code—it is
not even routinely built and thus prone to bitrot.

Cheers,
—Adrián
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20201013/59644de3/attachment.bin>