[webkit-dev] Embedding Identifiers in Commit Messages

Ryosuke Niwa rniwa at webkit.org
Mon Nov 2 15:09:31 PST 2020

On Mon, Nov 2, 2020 at 2:04 PM Jonathan Bedard <jbedard at apple.com> wrote:
> We appreciate everyone’s feedback on transitioning away from Subversion to Git, I’ll be releasing an expected timeline of up-coming changes in the next week before the contributors meeting.
> In the mean time, we’re preparing on adding identifiers to new commit messages, that work is tracked in https://bugs.webkit.org/show_bug.cgi?id=218407. At the moment, we’re likely going to be appending the identifiers to commit messages (as the current change proposes), but I wanted to provide a chance for folks to object to this change before it becomes canonical.

I'm a bit confused here. It looks like the patch only affects commits
made via webkit-patch. Given there are a lot of people who don't use
webkit-patch land, I'm not certain this strategy is sound even in the
short term. Furthermore, the proposed patch seems to have a race
condition when multiple commits are made concurrency? Why don't we do
this in post commit hook instead?

- R. Niwa

More information about the webkit-dev mailing list