[webkit-dev] Suggesting to enable paint timing by default
Maciej Stachowiak
mjs at apple.com
Wed Aug 19 20:26:33 PDT 2020
> On Jul 17, 2020, at 12:12 AM, Noam Rosenthal <noam at webkit.org> wrote:
>
>
>
> On Thu, Jul 16, 2020 at 11:03 PM Keith Miller <keith_miller at apple.com <mailto:keith_miller at apple.com>> wrote:
> Results appear to be neutral on the page load time benchmark, so you should be good on that front. I don’t know who the best person to vet the maturity of the code is though, sorry.
>
> Thanks a lot Keith, I appreciate it!
> @Maciej Stachowiak <mailto:mjs at apple.com>, what would be a good way to assert whether the code maturity is good enough to enable paint timing by default?
> The original code was reviewed by smfr and initially by zalan. It's covered by over 30 tests, mostly WPT, and A/B tests show no effect on load times as per Keith's check.
> Would asking for additional reviews be the next step? From whom?
At this point, if a reviewer approves a patch to enable it by default on trunk, I think you are good to go.
As a courtesy to Apple, I’d ask you to hold off on landing until mid-September, but that is optional.
- Maciej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20200819/d63cd123/attachment.htm>
More information about the webkit-dev
mailing list