[webkit-dev] JSC EWS being too optimistic

Aakash Jain aakash_jain at apple.com
Wed Oct 9 08:35:00 PDT 2019


Hi Caio,

Thanks for reporting this issue.

Jonathan fixed the bug you reported (https://bugs.webkit.org/show_bug.cgi?id=202419 <https://bugs.webkit.org/show_bug.cgi?id=202419>). It was a regression from a recent change.

I verified the fix using the same patch you tested with earlier. jsc EWS is now (correctly) failing on that patch (https://bugs.webkit.org/show_bug.cgi?id=202140 <https://bugs.webkit.org/show_bug.cgi?id=202140>). Please let me know if you notice any issue.

Thanks
Aakash

> On Oct 3, 2019, at 10:14 AM, Caio Lima <ticaiolima at gmail.com> wrote:
> 
> Hi all.
> 
> I've noticed that JSC bots (jsc, jsc-armv7, jsc-mips, jsc-386) are
> marking every patch as success, even if there is a build failure (see
> https://bug-202140-attachments.webkit.org/attachment.cgi?id=379917 for
> https://bugs.webkit.org/show_bug.cgi?id=202140). Is it already in
> someone's radar?If not, could anybody take a look on this? I tried to
> investigate, but I'm lacking knowledge of EWS code base. This already
> caused some noise into JSC patches that broke ARMv7 and MIPS ports. I
> opened this bug to report it
> https://bugs.webkit.org/show_bug.cgi?id=202419.
> 
> Thanks in advance,
> Caio Lima.
> _______________________________________________
> webkit-dev mailing list
> webkit-dev at lists.webkit.org
> https://lists.webkit.org/mailman/listinfo/webkit-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-dev/attachments/20191009/78a6bf16/attachment.html>


More information about the webkit-dev mailing list